From: Gary Bisson <bisson.gary@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "meta-freescale@yoctoproject.org"
<meta-freescale@yoctoproject.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: [PATCH 2/2][dizzy-next] linux-imx: add clock patch for T1.0 version of i.MX6Q
Date: Wed, 03 Dec 2014 11:07:38 -0800 [thread overview]
Message-ID: <547F5F7A.1060506@gmail.com> (raw)
In-Reply-To: <CAOMZO5An80N7wftZHrwVns1zUJ6O6E7yYsgNXNUKf2mgHCq6Jg@mail.gmail.com>
Hi Fabio,
On 12/03/2014 10:46 AM, Fabio Estevam wrote:
> Hi Gary,
>
>> @@ -0,0 +1,33 @@
>> +From ffcd8b98f6ba3a2b7a4aecc1e5e454de5fa5c4c3 Mon Sep 17 00:00:00 2001
>> +From: Gary Bisson <bisson.gary@gmail.com>
>> +Date: Tue, 2 Dec 2014 22:11:14 -0800
>> +Subject: [PATCH] ARM: clk-imx6q: fix video divider for revision 1.0 of i.MX6q
>> +
>> +As post dividers do not work on i.MX6Q revision 1.0 they must be fixed
>> +to 1. As the table index was wrong, a divider a of 4 could still be
>> +requested which implied the clock not to be set properly. This is the
>> +root cause of the HDMI not working at high resolution on T1.0 version of
>> +the SoC, giving the following error:
>> +mxc_sdc_fb fb.27: timeout when waiting for flip irq
>> +
>> +Signed-off-by: Gary Bisson <bisson.gary@gmail.com>
>> +---
>> + arch/arm/mach-imx/clk-imx6q.c | 2 +-
>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>> +
>> +diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c
>> +index e09b1e8..1e5c410 100644
>> +--- a/arch/arm/mach-imx/clk-imx6q.c
>> ++++ b/arch/arm/mach-imx/clk-imx6q.c
>> +@@ -279,7 +279,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
>> + post_div_table[1].div = 1;
>> + post_div_table[2].div = 1;
>> + video_div_table[1].div = 1;
>> +- video_div_table[2].div = 1;
>> ++ video_div_table[3].div = 1;
> Could you please fix the mainline kernel and send a patch to the
> linux-arm-kernel mailing list?
>
> Please also Cc shawn.guo@linaro.org.
>
> Regards,
>
> Fabio Estevam
>
> Thanks
As explained on my coverletter, this patch fixes HDMI up to 1080p30 but
doesn't work on 1080p60 which implies that I cannot really test it on
mainline.
I plan on working on this issue later this week and only then plan on
submitting it to the mainline.
Do you think it'd be better to add this one first today and later on add
the one that allows the testing?
Thanks,
Gary
next prev parent reply other threads:[~2014-12-03 19:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 17:07 [PATCH 0/2][dizzy-next] linux-imx: add clock fix for T1.0 Gary Bisson
2014-12-03 17:07 ` [PATCH 1/2][dizzy-next] linux-imx: remove unnecessary patches for 3.10.17-1.0.2 Gary Bisson
2014-12-03 17:29 ` Daiane Angolini
2014-12-03 17:33 ` Otavio Salvador
2014-12-03 18:13 ` Gary Bisson
2014-12-03 17:07 ` [PATCH 2/2][dizzy-next] linux-imx: add clock patch for T1.0 version of i.MX6Q Gary Bisson
2014-12-03 17:24 ` Daiane Angolini
2014-12-03 18:39 ` Eric Nelson
2014-12-03 18:46 ` Fabio Estevam
2014-12-03 19:07 ` Gary Bisson [this message]
2014-12-03 19:10 ` Fabio Estevam
2014-12-03 19:14 ` Gary Bisson
2014-12-03 19:17 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F5F7A.1060506@gmail.com \
--to=bisson.gary@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=meta-freescale@yoctoproject.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.