All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.3] configure: Replace which(1) with "has"
Date: Thu, 04 Dec 2014 07:30:57 +0100	[thread overview]
Message-ID: <547FFFA1.1090505@weilnetz.de> (raw)
In-Reply-To: <1417673896-14832-1-git-send-email-famz@redhat.com>

Am 04.12.2014 um 07:18 schrieb Fam Zheng:
> Using "has" is more slick because which(1) is not always there.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 47048f0..cae588c 100755
> --- a/configure
> +++ b/configure
> @@ -2727,7 +2727,7 @@ fi
>  if test "$modules" = yes; then
>      shacmd_probe="sha1sum sha1 shasum"
>      for c in $shacmd_probe; do
> -        if which $c >/dev/null 2>&1; then
> +        if has $c; then
>              shacmd="$c"
>              break
>          fi


Reviewed-by: Stefan Weil <sw@weilnetz.de>



WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH for-2.3] configure: Replace which(1) with "has"
Date: Thu, 04 Dec 2014 07:30:57 +0100	[thread overview]
Message-ID: <547FFFA1.1090505@weilnetz.de> (raw)
In-Reply-To: <1417673896-14832-1-git-send-email-famz@redhat.com>

Am 04.12.2014 um 07:18 schrieb Fam Zheng:
> Using "has" is more slick because which(1) is not always there.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 47048f0..cae588c 100755
> --- a/configure
> +++ b/configure
> @@ -2727,7 +2727,7 @@ fi
>  if test "$modules" = yes; then
>      shacmd_probe="sha1sum sha1 shasum"
>      for c in $shacmd_probe; do
> -        if which $c >/dev/null 2>&1; then
> +        if has $c; then
>              shacmd="$c"
>              break
>          fi


Reviewed-by: Stefan Weil <sw@weilnetz.de>

  reply	other threads:[~2014-12-04  6:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  6:18 [Qemu-trivial] [PATCH for-2.3] configure: Replace which(1) with "has" Fam Zheng
2014-12-04  6:18 ` [Qemu-devel] " Fam Zheng
2014-12-04  6:30 ` Stefan Weil [this message]
2014-12-04  6:30   ` Stefan Weil
2014-12-04  6:40 ` [Qemu-trivial] " Amos Kong
2014-12-04  6:40   ` Amos Kong
2014-12-10  8:36 ` [Qemu-trivial] " Michael Tokarev
2014-12-10  8:36   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547FFFA1.1090505@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.