From: Andrew Jackson <Andrew.Jackson@arm.com>
To: rajeev kumar <rajeevkumar.linux@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>, Liviu Dudau <Liviu.Dudau@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts
Date: Thu, 04 Dec 2014 09:07:51 +0000 [thread overview]
Message-ID: <54802467.4000702@arm.com> (raw)
In-Reply-To: <CAA7nrth+h32Un2C4z106wL181eru7hwFDxMdS00X55h5Zw=-Vg@mail.gmail.com>
On 12/04/14 06:43, rajeev kumar wrote:
> On Thu, Dec 4, 2014 at 12:10 PM, rajeev kumar
> <rajeevkumar.linux@gmail.com> wrote:
>> On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown <broonie@kernel.org> wrote:
>>> On Wed, Dec 03, 2014 at 04:38:55PM +0000, Andrew Jackson wrote:
>>>
>>>> case SNDRV_PCM_TRIGGER_STOP:
>>>> case SNDRV_PCM_TRIGGER_SUSPEND:
>>>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>>> - dev->active--;
>>>> + if (dev->active > 0)
>>>> + dev->active--;
>>>
>>> How is this triggering - this sounds like you're papering over some
>>> other bug somewhere?
>
> This check can be removed as it is not going to triggered.
As I said in my email to Mark, I couldn't convince myself that STOP/SUSPEND would only be called once so it seemed like a loophole which /might/ result in the device not functioning correctly.
If this can never happen, I'll drop the patch.
Andrew
> B'rgds
> ~Rajeev
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew.Jackson@arm.com (Andrew Jackson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts
Date: Thu, 04 Dec 2014 09:07:51 +0000 [thread overview]
Message-ID: <54802467.4000702@arm.com> (raw)
In-Reply-To: <CAA7nrth+h32Un2C4z106wL181eru7hwFDxMdS00X55h5Zw=-Vg@mail.gmail.com>
On 12/04/14 06:43, rajeev kumar wrote:
> On Thu, Dec 4, 2014 at 12:10 PM, rajeev kumar
> <rajeevkumar.linux@gmail.com> wrote:
>> On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown <broonie@kernel.org> wrote:
>>> On Wed, Dec 03, 2014 at 04:38:55PM +0000, Andrew Jackson wrote:
>>>
>>>> case SNDRV_PCM_TRIGGER_STOP:
>>>> case SNDRV_PCM_TRIGGER_SUSPEND:
>>>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>>> - dev->active--;
>>>> + if (dev->active > 0)
>>>> + dev->active--;
>>>
>>> How is this triggering - this sounds like you're papering over some
>>> other bug somewhere?
>
> This check can be removed as it is not going to triggered.
As I said in my email to Mark, I couldn't convince myself that STOP/SUSPEND would only be called once so it seemed like a loophole which /might/ result in the device not functioning correctly.
If this can never happen, I'll drop the patch.
Andrew
> B'rgds
> ~Rajeev
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jackson <Andrew.Jackson@arm.com>
To: rajeev kumar <rajeevkumar.linux@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Liviu Dudau <Liviu.Dudau@arm.com>
Subject: Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts
Date: Thu, 04 Dec 2014 09:07:51 +0000 [thread overview]
Message-ID: <54802467.4000702@arm.com> (raw)
In-Reply-To: <CAA7nrth+h32Un2C4z106wL181eru7hwFDxMdS00X55h5Zw=-Vg@mail.gmail.com>
On 12/04/14 06:43, rajeev kumar wrote:
> On Thu, Dec 4, 2014 at 12:10 PM, rajeev kumar
> <rajeevkumar.linux@gmail.com> wrote:
>> On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown <broonie@kernel.org> wrote:
>>> On Wed, Dec 03, 2014 at 04:38:55PM +0000, Andrew Jackson wrote:
>>>
>>>> case SNDRV_PCM_TRIGGER_STOP:
>>>> case SNDRV_PCM_TRIGGER_SUSPEND:
>>>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>>> - dev->active--;
>>>> + if (dev->active > 0)
>>>> + dev->active--;
>>>
>>> How is this triggering - this sounds like you're papering over some
>>> other bug somewhere?
>
> This check can be removed as it is not going to triggered.
As I said in my email to Mark, I couldn't convince myself that STOP/SUSPEND would only be called once so it seemed like a loophole which /might/ result in the device not functioning correctly.
If this can never happen, I'll drop the patch.
Andrew
> B'rgds
> ~Rajeev
>
next prev parent reply other threads:[~2014-12-04 9:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 16:38 [PATCH 2/5] ASoC: dwc: Don't allow negative use counts Andrew Jackson
2014-12-03 16:38 ` Andrew Jackson
2014-12-03 17:25 ` Mark Brown
2014-12-03 17:25 ` Mark Brown
2014-12-04 6:40 ` rajeev kumar
2014-12-04 6:40 ` rajeev kumar
2014-12-04 6:40 ` rajeev kumar
2014-12-04 6:43 ` rajeev kumar
2014-12-04 6:43 ` rajeev kumar
2014-12-04 9:07 ` Andrew Jackson [this message]
2014-12-04 9:07 ` Andrew Jackson
2014-12-04 9:07 ` Andrew Jackson
2014-12-04 9:00 ` Andrew Jackson
2014-12-04 9:00 ` Andrew Jackson
2014-12-04 9:00 ` Andrew Jackson
2014-12-04 10:51 ` Mark Brown
2014-12-04 10:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54802467.4000702@arm.com \
--to=andrew.jackson@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajeevkumar.linux@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.