From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()
Date: Thu, 04 Dec 2014 12:17:32 -0700 [thread overview]
Message-ID: <5480B34C.1040706@redhat.com> (raw)
In-Reply-To: <87mw73snpo.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 12/04/2014 03:39 AM, Markus Armbruster wrote:
> As per standard operating procedure, I expanded tabs in the lines I
> touched. No visual difference, except in patches.
>
> What do you want me to do?
>
> 1. Don't expand tabs, ignore checkpatch.pl whining
>
> 2. Expand tabs in touched lines (current patch)
>
> 3. Expand all tabs in uri_resolve() (in a separate patch, of course)
>
> 4. Expand all tabs in util/uri.c (in a separate patch, of course)
My preferred choice first: 2, 4, 3, 1
That is, I'm fine with how you did it. If you are going to clean up
tabs as a separate patch, I'd prefer you do it for the whole file rather
than just one function. And I'd rather a tab cleanup than ignoring
checkpatch.pl, but not at the expense of favoring a tab cleanup ahead of
the current proposed patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()
Date: Thu, 04 Dec 2014 12:17:32 -0700 [thread overview]
Message-ID: <5480B34C.1040706@redhat.com> (raw)
In-Reply-To: <87mw73snpo.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 12/04/2014 03:39 AM, Markus Armbruster wrote:
> As per standard operating procedure, I expanded tabs in the lines I
> touched. No visual difference, except in patches.
>
> What do you want me to do?
>
> 1. Don't expand tabs, ignore checkpatch.pl whining
>
> 2. Expand tabs in touched lines (current patch)
>
> 3. Expand all tabs in uri_resolve() (in a separate patch, of course)
>
> 4. Expand all tabs in util/uri.c (in a separate patch, of course)
My preferred choice first: 2, 4, 3, 1
That is, I'm fine with how you did it. If you are going to clean up
tabs as a separate patch, I'd prefer you do it for the whole file rather
than just one function. And I'd rather a tab cleanup than ignoring
checkpatch.pl, but not at the expense of favoring a tab cleanup ahead of
the current proposed patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-12-04 19:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 9:26 [Qemu-trivial] [PATCH] Drop superfluous conditionals around g_strdup() Markus Armbruster
2014-12-04 9:26 ` [Qemu-devel] " Markus Armbruster
2014-12-04 9:34 ` [Qemu-trivial] " Fam Zheng
2014-12-04 9:34 ` Fam Zheng
2014-12-04 10:39 ` [Qemu-trivial] " Markus Armbruster
2014-12-04 10:39 ` Markus Armbruster
2014-12-04 11:45 ` [Qemu-trivial] " Fam Zheng
2014-12-04 11:45 ` Fam Zheng
2014-12-04 12:43 ` [Qemu-trivial] " Markus Armbruster
2014-12-04 12:43 ` Markus Armbruster
2014-12-04 19:17 ` Eric Blake [this message]
2014-12-04 19:17 ` Eric Blake
2014-12-04 19:22 ` [Qemu-trivial] " Eric Blake
2014-12-04 19:22 ` Eric Blake
2014-12-10 8:31 ` [Qemu-trivial] " Michael Tokarev
2014-12-10 8:31 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5480B34C.1040706@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.