* [meta-oe][PATCH 1/2] mplayer2: use B = "${S}"
@ 2014-12-05 11:40 Awais Belal
2014-12-05 11:41 ` [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories Awais Belal
2014-12-05 11:44 ` [meta-oe][PATCH 1/2] mplayer2: use B = "${S}" Gary Thomas
0 siblings, 2 replies; 5+ messages in thread
From: Awais Belal @ 2014-12-05 11:40 UTC (permalink / raw)
To: openembedded-devel
The mplayer2 package does not support out of tree builds
and the do_configure step also tries to find the configure
script in the same build directory while the script lies in
the src directory.
This patch updates the builddir to point to the srcdir in
order to cope with the above issues.
Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 65fab1f..4656057 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -29,6 +29,7 @@ PR = "r13"
PARALLEL_MAKE = ""
S = "${WORKDIR}/git"
+B = "${S}"
FILES_${PN} = "${bindir}/mplayer ${libdir} /usr/etc/mplayer/"
CONFFILES_${PN} += "/usr/etc/mplayer/input.conf \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories
2014-12-05 11:40 [meta-oe][PATCH 1/2] mplayer2: use B = "${S}" Awais Belal
@ 2014-12-05 11:41 ` Awais Belal
2014-12-05 12:48 ` Martin Jansa
2014-12-05 11:44 ` [meta-oe][PATCH 1/2] mplayer2: use B = "${S}" Gary Thomas
1 sibling, 1 reply; 5+ messages in thread
From: Awais Belal @ 2014-12-05 11:41 UTC (permalink / raw)
To: openembedded-devel
The mplayer "make install" phase leaves an empty
/usr/lib directory seemingly regardless of the setting
of libdir. Remove it to avoid a packaging warning.
Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 4656057..7e6ff0d 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -142,4 +142,5 @@ do_install() {
install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
+ [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories
2014-12-05 11:41 ` [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories Awais Belal
@ 2014-12-05 12:48 ` Martin Jansa
2014-12-05 21:45 ` Belal, Awais
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2014-12-05 12:48 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
On Fri, Dec 05, 2014 at 04:41:00PM +0500, Awais Belal wrote:
> The mplayer "make install" phase leaves an empty
> /usr/lib directory seemingly regardless of the setting
> of libdir. Remove it to avoid a packaging warning.
Any idea why I'm not using both these issues in world builds?
Are you using the recipe exactly as is with PNBLACKLIST removed in your
distro and PREFERRED_VERSION for newer libav?
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 4656057..7e6ff0d 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -142,4 +142,5 @@ do_install() {
> install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
> + [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
> }
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories
2014-12-05 12:48 ` Martin Jansa
@ 2014-12-05 21:45 ` Belal, Awais
0 siblings, 0 replies; 5+ messages in thread
From: Belal, Awais @ 2014-12-05 21:45 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org
Hi Martin,
I am using an x86_64 machine, the latest world build qa.log from http://logs.nslu2-linux.org/buildlogs/oe/world//log.world.20141203_140839.log// does not seem to be building mplayer2.
I have libav PREFFERED_VERSION set and PNBLACKLIST[mplayer2] set empty as you've indicated.
BR,
Awais
________________________________________
From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Martin Jansa [martin.jansa@gmail.com]
Sent: Friday, December 05, 2014 5:48 PM
To: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories
On Fri, Dec 05, 2014 at 04:41:00PM +0500, Awais Belal wrote:
> The mplayer "make install" phase leaves an empty
> /usr/lib directory seemingly regardless of the setting
> of libdir. Remove it to avoid a packaging warning.
Any idea why I'm not using both these issues in world builds?
Are you using the recipe exactly as is with PNBLACKLIST removed in your
distro and PREFERRED_VERSION for newer libav?
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 4656057..7e6ff0d 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -142,4 +142,5 @@ do_install() {
> install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
> + [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
> }
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-oe][PATCH 1/2] mplayer2: use B = "${S}"
2014-12-05 11:40 [meta-oe][PATCH 1/2] mplayer2: use B = "${S}" Awais Belal
2014-12-05 11:41 ` [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories Awais Belal
@ 2014-12-05 11:44 ` Gary Thomas
1 sibling, 0 replies; 5+ messages in thread
From: Gary Thomas @ 2014-12-05 11:44 UTC (permalink / raw)
To: openembedded-devel
On 2014-12-05 04:40, Awais Belal wrote:
> The mplayer2 package does not support out of tree builds
> and the do_configure step also tries to find the configure
> script in the same build directory while the script lies in
> the src directory.
> This patch updates the builddir to point to the srcdir in
> order to cope with the above issues.
>
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 65fab1f..4656057 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -29,6 +29,7 @@ PR = "r13"
> PARALLEL_MAKE = ""
>
> S = "${WORKDIR}/git"
> +B = "${S}"
>
> FILES_${PN} = "${bindir}/mplayer ${libdir} /usr/etc/mplayer/"
> CONFFILES_${PN} += "/usr/etc/mplayer/input.conf \
>
It would probably be better to just inherit autoconf-brokensep
which does the same thing but documents the reason for the change.
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-05 21:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 11:40 [meta-oe][PATCH 1/2] mplayer2: use B = "${S}" Awais Belal
2014-12-05 11:41 ` [meta-oe][PATCH 2/2] mplayer2: cleanup empty directories Awais Belal
2014-12-05 12:48 ` Martin Jansa
2014-12-05 21:45 ` Belal, Awais
2014-12-05 11:44 ` [meta-oe][PATCH 1/2] mplayer2: use B = "${S}" Gary Thomas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.