Re: [review-request] michaelw/toaster/import-layers

[Michael Wood <michael.g.wood@intel.com>]

On 05/12/14 14:01, Barros Pena, Belen wrote:
> On 04/12/2014 16:55, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> New review request: updated functionality (pushed to same branch
>> poky-contrib michaelw/toaster/import-layers)
> This is looking really good from the UI side. I only found a couple of
> small things that I could fix myself. I've pushed them to
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/impo
> rt-layers2
>
> Michael: could you review and merge them to your branch if they are ok?

Great thanks.

> There is just one more issue: the content of the notifications shown in
> the project page when you import a layer. I am really keeping an eye in
> all our notifications to make sure their content has a certain
> consistency. When you add layers to a project we include in the
> notifications:
>
> 1. The total number of layers added to the project
> 2. The names of each of the layers added, with the names being links to
> the corresponding layer details pages
>
> Currently, the notifications when you import and add a single layer are
> missing number 1 above: the name of the layer is not a link. The
> notifications when you import a layer but add several of them due to
> dependencies are missing both 1 and 2 above.
>
> The notifications when you import a layer should look exactly like in the
> attached document. Is there any chance we could get those notifications
> changed?

Ah yes, I was going to mention that, currently this data would all have 
to be passed in using the URL e.g. the url you would be redirected to 
would be like 
http://127.0.0.1:8000/toastergui/project/3/#/layerimported=intel-arduino,deps=meta-imported,meta-efl,meta-intel,meta-multimedia,meta-oe,meta-ruby 
<like%20http://127.0.0.1:8000/toastergui/project/3/#/layerimported?layer=intel-arduino?deps=meta-imported,%20meta-efl,meta-intel,meta-multimedia,meta-oe,meta-ruby> 
etc… then that string would need to be parsed into the right parts for 
the error message.

However thinking about it again it should be possible to use the session 
cookie to do this. I'll investigate.

> Thanks!
>
> Belén
>
>
>> Thanks,
>>
>> Michael
>>
>> On 01/12/14 14:27, Damian, Alexandru wrote:
>>> Since we're rolling this back, just a note on adding layerversions -
>>>
>>> For all imported layerversion, the project field MUST be set to
>>> current project - otherwise branches with a name different from
>>> project release name won't show up in the current project.
>>>
>>> On Mon, Dec 1, 2014 at 11:27 AM, Damian, Alexandru
>>> <alexandru.damian@intel.com <mailto:alexandru.damian@intel.com>> wrote:
>>>
>>>      Thank you, taken for submission !
>>>
>>>      On Fri, Nov 28, 2014 at 8:32 PM, Michael Wood
>>>      <michael.g.wood@intel.com <mailto:michael.g.wood@intel.com>> wrote:
>>>
>>>          poky-contrib michaelw/toaster/import-layers
>>>
>>>          bitbake: toaster: Add import layer feature
>>>          bitbake: toaster: libtoaster Add editProject and
>>>          getLayerDepsForProject
>>>          bitbake: toaster: libtoaster Add a error handler to GET in
>>>          makeTypehead
>>>
>>>          Thanks,
>>>
>>>          Michael
>>>          --
>>>          _______________________________________________
>>>          toaster mailing list
>>>          toaster@yoctoproject.org <mailto:toaster@yoctoproject.org>
>>>          https://lists.yoctoproject.org/listinfo/toaster
>>>
>>>
>>>
>>>
>>>      --
>>>      Alex Damian
>>>      Yocto Project
>>>      SSG / OTC
>>>
>>>
>>>
>>>
>>> -- 
>>> Alex Damian
>>> Yocto Project
>>> SSG / OTC
>>>
>>> ---------------------------------------------------------------------
>>> Intel Corporation (UK) Limited
>>> Registered No. 1134945 (England)
>>> Registered Office: Pipers Way, Swindon SN3 1RJ
>>> VAT No: 860 2173 47
>>>
>>> This e-mail and any attachments may contain confidential material for
>>> the sole use of the intended recipient(s). Any review or distribution
>>> by others is strictly prohibited. If you are not the intended
>>> recipient, please contact the sender and delete all copies.
>>>
>> -- 
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster