All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>,
	Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] have architectures specify the number of PIRQs a hardware domain gets
Date: Fri, 5 Dec 2014 14:48:43 +0000	[thread overview]
Message-ID: <5481C5CB.3010103@citrix.com> (raw)
In-Reply-To: <5481C67D020000780004D2D1@mail.emea.novell.com>

On 05/12/14 13:51, Jan Beulich wrote:
> The current value of nr_static_irqs + 256 is often too small for larger
> systems. Make it dependent on CPU count and number of IO-APIC pins on
> x86, and (until it obtains PCI support) simply NR_IRQS on ARM.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I obviously prefer the simpler version that removes an unnecessary
configuration option. But in the sense that this resolves the immediate
problem at least for the short to medium term:

Acked-by: David Vrabel <david.vrabel@citrix.com>

> +            d->nr_pirqs = extra_hwdom_irqs ? nr_static_irqs + extra_hwdom_irqs
> +                                           : arch_hwdom_irqs(domid);

This means if the user asks for 0 extra (by the command line) for hwdoms
they get the default which non-obvious.

David

  parent reply	other threads:[~2014-12-05 14:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 13:51 [PATCH] have architectures specify the number of PIRQs a hardware domain gets Jan Beulich
2014-12-05 14:27 ` Ian Campbell
2014-12-05 14:36   ` Julien Grall
2014-12-05 14:42     ` Ian Campbell
2014-12-05 15:25       ` Julien Grall
2014-12-05 15:42         ` Jan Beulich
2014-12-05 16:05           ` Julien Grall
2014-12-05 16:23             ` Jan Beulich
2014-12-05 16:34               ` Stefano Stabellini
2014-12-05 14:48   ` Jan Beulich
2014-12-05 14:51     ` Ian Campbell
2014-12-11 12:07       ` Ian Campbell
2014-12-11 13:16         ` Jan Beulich
2014-12-05 14:48 ` David Vrabel [this message]
2014-12-05 14:54   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5481C5CB.3010103@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.