From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>, Eric Wheeler <ewheeler@ewheeler.net>
Cc: dm-devel@redhat.com, ejt@redhat.com,
LVM2 development <lvm-devel@redhat.com>
Subject: Re: [PATCH] dm thin: optimize away writing all zeroes to unprovisioned blocks
Date: Fri, 05 Dec 2014 10:27:56 -0700 [thread overview]
Message-ID: <5481EB1C.4000202@kernel.dk> (raw)
In-Reply-To: <20141204153358.GA19315@redhat.com>
On 12/04/2014 08:33 AM, Mike Snitzer wrote:
>
> Here is a revised patch that is more like I'd expect to land upstream.
> Jens are you OK with us adding bio_is_zero_filled to block/bio.c? If so
> should I split it out as a separate patch for you to pick up or just
> carry it as part of the patch that lands in linux-dm.git?
Yeah I'm fine with adding that helper. I do wonder what the performance
impact is on this for dm. Have you tried a (worst case) test of writing
blocks that are zero filled, but with the last byte not being a zero?
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: lvm-devel@redhat.com
Subject: [PATCH] dm thin: optimize away writing all zeroes to unprovisioned blocks
Date: Fri, 05 Dec 2014 10:27:56 -0700 [thread overview]
Message-ID: <5481EB1C.4000202@kernel.dk> (raw)
In-Reply-To: <20141204153358.GA19315@redhat.com>
On 12/04/2014 08:33 AM, Mike Snitzer wrote:
>
> Here is a revised patch that is more like I'd expect to land upstream.
> Jens are you OK with us adding bio_is_zero_filled to block/bio.c? If so
> should I split it out as a separate patch for you to pick up or just
> carry it as part of the patch that lands in linux-dm.git?
Yeah I'm fine with adding that helper. I do wonder what the performance
impact is on this for dm. Have you tried a (worst case) test of writing
blocks that are zero filled, but with the last byte not being a zero?
--
Jens Axboe
next prev parent reply other threads:[~2014-12-05 17:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 18:38 dm-thinp feature request: skip allocation on writes of all zeroes Eric Wheeler
2014-09-30 19:30 ` Zdenek Kabelac
2014-09-30 20:13 ` Mike Snitzer
2014-09-30 22:38 ` Eric Wheeler
2014-12-04 7:05 ` [PATCH] dm-thinp: skip allocation on writes of all zeros to unallocated blocks Eric Wheeler
2014-12-04 7:25 ` Eric Wheeler
2014-12-04 15:33 ` [PATCH] dm thin: optimize away writing all zeroes to unprovisioned blocks Mike Snitzer
2014-12-04 15:33 ` Mike Snitzer
2014-12-04 15:43 ` Mike Snitzer
2014-12-04 15:43 ` Mike Snitzer
2014-12-06 22:33 ` Eric Wheeler
2014-12-06 22:33 ` Eric Wheeler
2014-12-05 14:47 ` Mike Snitzer
2014-12-05 14:47 ` Mike Snitzer
2014-12-06 22:36 ` Eric Wheeler
2014-12-06 22:36 ` Eric Wheeler
2014-12-05 17:27 ` Jens Axboe [this message]
2014-12-05 17:27 ` [PATCH] " Jens Axboe
2014-12-05 18:33 ` Mike Snitzer
2014-12-05 18:33 ` Mike Snitzer
2014-12-06 22:40 ` Eric Wheeler
2014-12-06 22:40 ` Eric Wheeler
2014-12-07 1:41 ` [lvm-devel] " Jens Axboe
2014-12-07 1:41 ` Jens Axboe
2014-12-07 6:30 ` Eric Wheeler
2014-12-07 6:30 ` Eric Wheeler
2014-12-07 6:45 ` Eric Wheeler
2014-12-07 6:45 ` Eric Wheeler
2014-12-08 16:57 ` [lvm-devel] " Jens Axboe
2014-12-08 16:57 ` Jens Axboe
2014-12-09 8:02 ` Eric Wheeler
2014-12-09 8:02 ` Eric Wheeler
2014-12-09 15:31 ` [lvm-devel] " Jens Axboe
2014-12-09 15:31 ` Jens Axboe
2014-12-09 15:41 ` [lvm-devel] " Jens Axboe
2014-12-09 15:41 ` Jens Axboe
2014-12-10 2:52 ` [PATCH] " Eric Wheeler
2014-12-10 2:52 ` Eric Wheeler
2015-01-26 2:53 ` Eric Wheeler
2015-01-26 2:53 ` Eric Wheeler
2015-02-15 0:31 ` [lvm-devel] " Eric Wheeler
2015-02-15 0:31 ` Eric Wheeler
2014-12-09 14:38 ` Marian Csontos
2014-12-09 14:38 ` Marian Csontos
2014-12-07 1:36 ` Jens Axboe
2014-12-07 1:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5481EB1C.4000202@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=ewheeler@ewheeler.net \
--cc=lvm-devel@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.