From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Broadcom STB GISB bus driver for 3.19 (v2)
Date: Fri, 05 Dec 2014 11:18:50 -0800 [thread overview]
Message-ID: <5482051A.1050403@gmail.com> (raw)
In-Reply-To: <6133066.hrdnRxXNp1@wuerfel>
On 05/12/14 01:54, Arnd Bergmann wrote:
> On Thursday 04 December 2014 23:23:49 Florian Fainelli wrote:
>> Le 04/12/2014 07:44, Arnd Bergmann a ?crit :
>>> On Friday 28 November 2014 16:19:30 Florian Fainelli wrote:
>>>> This pull request contains the following changes to the Broadcom GISB bus
>>>> arbiter from Kevin Cernekee:
>>>>
>>>> - Extend brcmstb GISB bus driver to work on MIPS (currently ARM-only) and support
>>>> 65nm and 40nm MIPS-based chips such as: BCM7038, BCM7400 and BCM7435
>>>
>>> Pulled into next/drivers, thanks!
>>
>> Thanks! You may have to resolve a conflict when you merge
>> brcm/stb-smp-uart with next/drivers for this file, especially with the
>> commit below:
>>
>> 203bb85ed605e43eadca62afb3a8cd128a8ec10a ("bus: brcmstb_gisb: save and
>> restore GISB timeout")
>>
>> for brcmstb_gisb_arb_suspend() and
>> brcmstb_gisb_arb_resume_noirq() which still use the ioread32/iowrite32
>> accessors instead of those introduced later on by Kevin: gisb_read() and
>> gisb_write. The merge resolution looks like this:
>>
>>
>> #ifdef CONFIG_PM_SLEEP
>> static int brcmstb_gisb_arb_suspend(struct device *dev)
>> {
>> struct platform_device *pdev = to_platform_device(dev);
>> struct brcmstb_gisb_arb_device *gdev = platform_get_drvdata(pdev);
>>
>> gdev->saved_timeout = gisb_read(gdev, ARB_TIMER);
>>
>> return 0;
>> }
>>
>> /* Make sure we provide the same timeout value that was configured
>> before, and
>> * do this before the GISB timeout interrupt handler has any chance to run.
>> */
>> static int brcmstb_gisb_arb_resume_noirq(struct device *dev)
>> {
>> struct platform_device *pdev = to_platform_device(dev);
>> struct brcmstb_gisb_arb_device *gdev = platform_get_drvdata(pdev);
>>
>> gisb_write(gdev, gdev->saved_timeout, ARB_TIMER);
>>
>> return 0;
>> }
>
> I ended up mismerging it actually, but Olof fixed it up. If you have the
> time, please check that the contents of our for-next branch are correct
> now.
I just sent you a fix applying on top of your for-next branch that
resolves this: 1417806943-1200-1-git-send-email-f.fainelli at gmail.com
I will put all the brcmstb_gisb in the same branch next time so you
don't have to resolve conflicts like these anymore.
Thanks!
>
> Thanks,
>
> Arnd
>
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [GIT PULL] Broadcom STB GISB bus driver for 3.19 (v2)
Date: Fri, 05 Dec 2014 11:18:50 -0800 [thread overview]
Message-ID: <5482051A.1050403@gmail.com> (raw)
In-Reply-To: <6133066.hrdnRxXNp1@wuerfel>
On 05/12/14 01:54, Arnd Bergmann wrote:
> On Thursday 04 December 2014 23:23:49 Florian Fainelli wrote:
>> Le 04/12/2014 07:44, Arnd Bergmann a écrit :
>>> On Friday 28 November 2014 16:19:30 Florian Fainelli wrote:
>>>> This pull request contains the following changes to the Broadcom GISB bus
>>>> arbiter from Kevin Cernekee:
>>>>
>>>> - Extend brcmstb GISB bus driver to work on MIPS (currently ARM-only) and support
>>>> 65nm and 40nm MIPS-based chips such as: BCM7038, BCM7400 and BCM7435
>>>
>>> Pulled into next/drivers, thanks!
>>
>> Thanks! You may have to resolve a conflict when you merge
>> brcm/stb-smp-uart with next/drivers for this file, especially with the
>> commit below:
>>
>> 203bb85ed605e43eadca62afb3a8cd128a8ec10a ("bus: brcmstb_gisb: save and
>> restore GISB timeout")
>>
>> for brcmstb_gisb_arb_suspend() and
>> brcmstb_gisb_arb_resume_noirq() which still use the ioread32/iowrite32
>> accessors instead of those introduced later on by Kevin: gisb_read() and
>> gisb_write. The merge resolution looks like this:
>>
>>
>> #ifdef CONFIG_PM_SLEEP
>> static int brcmstb_gisb_arb_suspend(struct device *dev)
>> {
>> struct platform_device *pdev = to_platform_device(dev);
>> struct brcmstb_gisb_arb_device *gdev = platform_get_drvdata(pdev);
>>
>> gdev->saved_timeout = gisb_read(gdev, ARB_TIMER);
>>
>> return 0;
>> }
>>
>> /* Make sure we provide the same timeout value that was configured
>> before, and
>> * do this before the GISB timeout interrupt handler has any chance to run.
>> */
>> static int brcmstb_gisb_arb_resume_noirq(struct device *dev)
>> {
>> struct platform_device *pdev = to_platform_device(dev);
>> struct brcmstb_gisb_arb_device *gdev = platform_get_drvdata(pdev);
>>
>> gisb_write(gdev, gdev->saved_timeout, ARB_TIMER);
>>
>> return 0;
>> }
>
> I ended up mismerging it actually, but Olof fixed it up. If you have the
> time, please check that the contents of our for-next branch are correct
> now.
I just sent you a fix applying on top of your for-next branch that
resolves this: 1417806943-1200-1-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
I will put all the brcmstb_gisb in the same branch next time so you
don't have to resolve conflicts like these anymore.
Thanks!
>
> Thanks,
>
> Arnd
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-05 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 0:19 [GIT PULL] Broadcom STB GISB bus driver for 3.19 (v2) Florian Fainelli
2014-11-29 0:19 ` Florian Fainelli
2014-12-04 15:44 ` Arnd Bergmann
2014-12-04 15:44 ` Arnd Bergmann
2014-12-05 7:23 ` Florian Fainelli
2014-12-05 7:23 ` Florian Fainelli
2014-12-05 9:54 ` Arnd Bergmann
2014-12-05 9:54 ` Arnd Bergmann
2014-12-05 19:18 ` Florian Fainelli [this message]
2014-12-05 19:18 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5482051A.1050403@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.