From: Chen Gang <gang.chen.5i5j@gmail.com>
To: hannes@cmpxchg.org, mhocko@suse.cz
Cc: cgroups@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: [PATCH] mm: memcontrol: Skip test_mem_cgroup_node_reclaimable() when no MAX_NUMNODES or not more than 1
Date: Sat, 06 Dec 2014 06:27:57 +0800 [thread overview]
Message-ID: <5482316D.607@gmail.com> (raw)
test_mem_cgroup_node_reclaimable() is only used when "MAX_NUMNODES > 1",
so move it into related quote.
The related warning (with allmodconfig under parisc):
CC mm/memcontrol.o
mm/memcontrol.c:1629:13: warning: 'test_mem_cgroup_node_reclaimable' defined but not used [-Wunused-function]
static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index c6ac50e..d538b08 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1616,6 +1616,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
NULL, "Memory cgroup out of memory");
}
+#if MAX_NUMNODES > 1
/**
* test_mem_cgroup_node_reclaimable
* @memcg: the target memcg
@@ -1638,7 +1639,6 @@ static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
return false;
}
-#if MAX_NUMNODES > 1
/*
* Always updating the nodemask is not very good - even if we have an empty
--
1.9.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: hannes@cmpxchg.org, mhocko@suse.cz
Cc: cgroups@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: [PATCH] mm: memcontrol: Skip test_mem_cgroup_node_reclaimable() when no MAX_NUMNODES or not more than 1
Date: Sat, 06 Dec 2014 06:27:57 +0800 [thread overview]
Message-ID: <5482316D.607@gmail.com> (raw)
test_mem_cgroup_node_reclaimable() is only used when "MAX_NUMNODES > 1",
so move it into related quote.
The related warning (with allmodconfig under parisc):
CC mm/memcontrol.o
mm/memcontrol.c:1629:13: warning: 'test_mem_cgroup_node_reclaimable' defined but not used [-Wunused-function]
static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index c6ac50e..d538b08 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1616,6 +1616,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
NULL, "Memory cgroup out of memory");
}
+#if MAX_NUMNODES > 1
/**
* test_mem_cgroup_node_reclaimable
* @memcg: the target memcg
@@ -1638,7 +1639,6 @@ static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
return false;
}
-#if MAX_NUMNODES > 1
/*
* Always updating the nodemask is not very good - even if we have an empty
--
1.9.3
next reply other threads:[~2014-12-05 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 22:27 Chen Gang [this message]
2014-12-05 22:27 ` [PATCH] mm: memcontrol: Skip test_mem_cgroup_node_reclaimable() when no MAX_NUMNODES or not more than 1 Chen Gang
2014-12-07 10:33 ` Michal Hocko
2014-12-07 10:33 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2014-12-07 13:53 Chen Gang
2014-12-07 13:53 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5482316D.607@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.