From: Benjamin Larsson <benjamin@southpole.se>
To: Antti Palosaari <crope@iki.fi>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors
Date: Sat, 06 Dec 2014 15:27:33 +0100 [thread overview]
Message-ID: <54831255.6080800@southpole.se> (raw)
In-Reply-To: <5482FABE.3050004@iki.fi>
On 12/06/2014 01:46 PM, Antti Palosaari wrote:
> Moikka!
> I am very surprised about that patch, especially because it
> *increases* polling interval from 400ms to 200ms. For me it has been
> always worked rather well, but now I suspect it could be due to I
> disable always remote controller... I have to test that.
>
> regards
> Antti
I noticed that I got more retry errors when I removed the poll. So when
I tried lowering the interval time the errors totally disappeared for
me. Exactly how it works is unclear to me but I guess that the rc poll
triggers something in the chip to mitigate some overflow in the i2c
transmit buffer. This workaround also suggest that the i2c bus actually
is ok and not the cause for the errors. Anyway please test and if this
is an acceptable solution then there might also be some check that this
poll is active and set to 200 at all times for this card. At least when
the card is set in dvb mode, for sdr mode this might not be an issue.
MvH
Benjamin Larsson
next prev parent reply other threads:[~2014-12-06 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 0:25 [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors Benjamin Larsson
2014-12-06 0:25 ` [PATCH 2/3] mn88472: make sure the private data struct is nulled after free Benjamin Larsson
2014-12-06 16:29 ` Antti Palosaari
2014-12-06 18:08 ` Benjamin Larsson
2014-12-06 18:37 ` Antti Palosaari
2014-12-06 20:26 ` Benjamin Larsson
2015-01-19 13:15 ` Hans Verkuil
2015-01-19 18:38 ` Benjamin Larsson
2014-12-06 0:25 ` [PATCH 3/3] mn88472: add ts mode and ts clock to driver Benjamin Larsson
2014-12-06 16:31 ` Antti Palosaari
2014-12-06 12:46 ` [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors Antti Palosaari
2014-12-06 14:27 ` Benjamin Larsson [this message]
2015-02-19 9:44 ` Benjamin Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54831255.6080800@southpole.se \
--to=benjamin@southpole.se \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.