From: Antti Palosaari <crope@iki.fi>
To: Benjamin Larsson <benjamin@southpole.se>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/3] mn88472: make sure the private data struct is nulled after free
Date: Sat, 06 Dec 2014 20:37:11 +0200 [thread overview]
Message-ID: <54834CD7.1060709@iki.fi> (raw)
In-Reply-To: <54834628.50702@southpole.se>
On 12/06/2014 08:08 PM, Benjamin Larsson wrote:
> On 12/06/2014 05:29 PM, Antti Palosaari wrote:
>> But that is not needed anymore ?
>>
>> regards
>> Antti
>
> Chances are that more devices with the mn8847x chips appear. Someone
> somewhere might try to use this demod with the old dvb attach model
> during development. Adding this memset will make the unload issue appear
> all the time instead of randomly. But this patch doesn't really matter
> so feel free to NACK it. I just wanted to post it for completeness.
>
> I do think it is good practice to set pointers to null generally as that
> would have saved me several days of work of whentracking down this bug.
> The current dvb framework contain several other cases where pointers are
> feed'd but not nulled.
There is kzfree() for that, but still I am very unsure should we start
zeroing memory upon release driver has allocated, or just relase it
using kfree.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-12-06 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 0:25 [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors Benjamin Larsson
2014-12-06 0:25 ` [PATCH 2/3] mn88472: make sure the private data struct is nulled after free Benjamin Larsson
2014-12-06 16:29 ` Antti Palosaari
2014-12-06 18:08 ` Benjamin Larsson
2014-12-06 18:37 ` Antti Palosaari [this message]
2014-12-06 20:26 ` Benjamin Larsson
2015-01-19 13:15 ` Hans Verkuil
2015-01-19 18:38 ` Benjamin Larsson
2014-12-06 0:25 ` [PATCH 3/3] mn88472: add ts mode and ts clock to driver Benjamin Larsson
2014-12-06 16:31 ` Antti Palosaari
2014-12-06 12:46 ` [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors Antti Palosaari
2014-12-06 14:27 ` Benjamin Larsson
2015-02-19 9:44 ` Benjamin Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54834CD7.1060709@iki.fi \
--to=crope@iki.fi \
--cc=benjamin@southpole.se \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.