All of lore.kernel.org
 help / color / mirror / Atom feed
* meta-fsl-ppc: questioning reason to disable reverse path filtering...
@ 2014-11-29 19:06 Bob Cochran
  2014-11-30  2:44 ` ting.liu
  2014-12-02  2:38 ` ting.liu
  0 siblings, 2 replies; 6+ messages in thread
From: Bob Cochran @ 2014-11-29 19:06 UTC (permalink / raw)
  To: meta-freescale@yoctoproject.org

Hi,

Reverse Path filtering (RPF) is disabled by 
meta-fsl-ppc/recipes-extended/procps_%.bbappend.

The git log states: "rp_filter causes issues with VLAN interfaces."

An email patch for procps from FSL back on 3/7/13 states:

"disable rp_filter to enhance ASF IP forward performance, which is 
really fsl SDK specific."

Are both of these statements true?

If so, it looks like AS_FASTPATH is almost always disabled by default in 
the powerpc defconfigs.  Therefore, if reverse path filtering issues are 
specific to AS_FASTPATH, I suggest RPF shouldn't be disabled by default. 
  Perhaps add a comment in the drivers/net/Kconfig help for AS_FASTPATH 
that if AS_FASTPATH is enabled, then disable RPF.

Regardless, can we get a description added to this recipe append file to 
document why it exists?   And if there is no need to disable RPF in 
default configurations, can we just get rid of it?

Thanks

Bob








^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: meta-fsl-ppc: questioning reason to disable reverse path filtering...
  2014-11-29 19:06 meta-fsl-ppc: questioning reason to disable reverse path filtering Bob Cochran
@ 2014-11-30  2:44 ` ting.liu
  2014-12-02  2:38 ` ting.liu
  1 sibling, 0 replies; 6+ messages in thread
From: ting.liu @ 2014-11-30  2:44 UTC (permalink / raw)
  To: Bob Cochran; +Cc: meta-freescale@yoctoproject.org

> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Sunday, November 30, 2014 3:06 AM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] meta-fsl-ppc: questioning reason to disable reverse
> path filtering...
> 
> Hi,
> 
> Reverse Path filtering (RPF) is disabled by meta-fsl-ppc/recipes-
> extended/procps_%.bbappend.
> 
> The git log states: "rp_filter causes issues with VLAN interfaces."
> 
> An email patch for procps from FSL back on 3/7/13 states:
> 
> "disable rp_filter to enhance ASF IP forward performance, which is really fsl
> SDK specific."
> 
> Are both of these statements true?
> 
> If so, it looks like AS_FASTPATH is almost always disabled by default in the
> powerpc defconfigs.  Therefore, if reverse path filtering issues are specific
> to AS_FASTPATH, I suggest RPF shouldn't be disabled by default.
>   Perhaps add a comment in the drivers/net/Kconfig help for AS_FASTPATH that
> if AS_FASTPATH is enabled, then disable RPF.
> 
> Regardless, can we get a description added to this recipe append file to
> document why it exists?   And if there is no need to disable RPF in
> default configurations, can we just get rid of it?
> 
[Liu Ting-B28495] Hi Bob, we will reply to you when the detailed info got from our dev/test team.

> Thanks
> 
> Bob
> 
> 
> 
> 
> 
> 
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: meta-fsl-ppc: questioning reason to disable reverse path filtering...
  2014-11-29 19:06 meta-fsl-ppc: questioning reason to disable reverse path filtering Bob Cochran
  2014-11-30  2:44 ` ting.liu
@ 2014-12-02  2:38 ` ting.liu
  2014-12-02  4:02   ` Bob Cochran
  1 sibling, 1 reply; 6+ messages in thread
From: ting.liu @ 2014-12-02  2:38 UTC (permalink / raw)
  To: Bob Cochran, Sandeep.Malik@freescale.com; +Cc: meta-freescale@yoctoproject.org

Hi Bob,

You are right. Below is the answer from Sandeep (added in):

"The RP_FILTER issues are specific to AS_FASTPATH and with current ASF implementation the RP_FILTER needs to be disabled. Since the ASF is disabled by default so the RP_FILTER can be enabled by default and the same can be disabled when someone enables the AS_FASTPATH."

-Ting

> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Sunday, November 30, 2014 3:06 AM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] meta-fsl-ppc: questioning reason to disable reverse
> path filtering...
> 
> Hi,
> 
> Reverse Path filtering (RPF) is disabled by meta-fsl-ppc/recipes-
> extended/procps_%.bbappend.
> 
> The git log states: "rp_filter causes issues with VLAN interfaces."
> 
> An email patch for procps from FSL back on 3/7/13 states:
> 
> "disable rp_filter to enhance ASF IP forward performance, which is really fsl
> SDK specific."
> 
> Are both of these statements true?
> 
> If so, it looks like AS_FASTPATH is almost always disabled by default in the
> powerpc defconfigs.  Therefore, if reverse path filtering issues are specific
> to AS_FASTPATH, I suggest RPF shouldn't be disabled by default.
>   Perhaps add a comment in the drivers/net/Kconfig help for AS_FASTPATH that
> if AS_FASTPATH is enabled, then disable RPF.
> 
> Regardless, can we get a description added to this recipe append file to
> document why it exists?   And if there is no need to disable RPF in
> default configurations, can we just get rid of it?
> 
> Thanks
> 
> Bob
> 
> 
> 
> 
> 
> 
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: meta-fsl-ppc: questioning reason to disable reverse path filtering...
  2014-12-02  2:38 ` ting.liu
@ 2014-12-02  4:02   ` Bob Cochran
  2014-12-05  8:22     ` zhenhua.luo
  0 siblings, 1 reply; 6+ messages in thread
From: Bob Cochran @ 2014-12-02  4:02 UTC (permalink / raw)
  To: ting.liu@freescale.com, Sandeep.Malik@freescale.com
  Cc: meta-freescale@yoctoproject.org

On 12/01/2014 09:38 PM, ting.liu@freescale.com wrote:
> Hi Bob,
>
> You are right. Below is the answer from Sandeep (added in):
>
> "The RP_FILTER issues are specific to AS_FASTPATH and with current ASF implementation the RP_FILTER needs to be disabled. Since the ASF is disabled by default so the RP_FILTER can be enabled by default and the same can be disabled when someone enables the AS_FASTPATH."
>


Thank you Ting.  What is the right way to patch this?  Can we remove the 
procps bbappend and add something to AS_FASTPATH Kconfig help as I had 
proposed?

If not, please propose what you would like to see.


> -Ting
>
>> -----Original Message-----
>> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
>> bounces@yoctoproject.org] On Behalf Of Bob Cochran
>> Sent: Sunday, November 30, 2014 3:06 AM
>> To: meta-freescale@yoctoproject.org
>> Subject: [meta-freescale] meta-fsl-ppc: questioning reason to disable reverse
>> path filtering...
>>
>> Hi,
>>
>> Reverse Path filtering (RPF) is disabled by meta-fsl-ppc/recipes-
>> extended/procps_%.bbappend.
>>
>> The git log states: "rp_filter causes issues with VLAN interfaces."
>>
>> An email patch for procps from FSL back on 3/7/13 states:
>>
>> "disable rp_filter to enhance ASF IP forward performance, which is really fsl
>> SDK specific."
>>
>> Are both of these statements true?
>>
>> If so, it looks like AS_FASTPATH is almost always disabled by default in the
>> powerpc defconfigs.  Therefore, if reverse path filtering issues are specific
>> to AS_FASTPATH, I suggest RPF shouldn't be disabled by default.
>>    Perhaps add a comment in the drivers/net/Kconfig help for AS_FASTPATH that
>> if AS_FASTPATH is enabled, then disable RPF.
>>
>> Regardless, can we get a description added to this recipe append file to
>> document why it exists?   And if there is no need to disable RPF in
>> default configurations, can we just get rid of it?
>>
>> Thanks
>>
>> Bob
>>
>>
>>
>>
>>
>>
>> --
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: meta-fsl-ppc: questioning reason to disable reverse path filtering...
  2014-12-02  4:02   ` Bob Cochran
@ 2014-12-05  8:22     ` zhenhua.luo
  2014-12-07 18:23       ` Bob Cochran
  0 siblings, 1 reply; 6+ messages in thread
From: zhenhua.luo @ 2014-12-05  8:22 UTC (permalink / raw)
  To: Bob Cochran, ting.liu@freescale.com, Sandeep.Malik@freescale.com
  Cc: meta-freescale@yoctoproject.org

Since the RP_FILTER options only influence the ASF performance, ASF is disabled by default, so the procps bbappend can be removed to enable the RP_FILTER options by default. 

The ASF document needs to be updated to tell users to disable RP_FILTER options when using ASF. 


Best Regards,

Zhenhua

> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Tuesday, December 02, 2014 12:02 PM
> To: Liu Ting-B28495; Malik Sandeep-B02416
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] meta-fsl-ppc: questioning reason to disable
> reverse path filtering...
> 
> On 12/01/2014 09:38 PM, ting.liu@freescale.com wrote:
> > Hi Bob,
> >
> > You are right. Below is the answer from Sandeep (added in):
> >
> > "The RP_FILTER issues are specific to AS_FASTPATH and with current ASF
> implementation the RP_FILTER needs to be disabled. Since the ASF is disabled
> by default so the RP_FILTER can be enabled by default and the same can be
> disabled when someone enables the AS_FASTPATH."
> >
> 
> 
> Thank you Ting.  What is the right way to patch this?  Can we remove the
> procps bbappend and add something to AS_FASTPATH Kconfig help as I had
> proposed?
> 
> If not, please propose what you would like to see.
> 
> 
> > -Ting
> >
> >> -----Original Message-----
> >> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> >> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> >> Sent: Sunday, November 30, 2014 3:06 AM
> >> To: meta-freescale@yoctoproject.org
> >> Subject: [meta-freescale] meta-fsl-ppc: questioning reason to disable
> >> reverse path filtering...
> >>
> >> Hi,
> >>
> >> Reverse Path filtering (RPF) is disabled by meta-fsl-ppc/recipes-
> >> extended/procps_%.bbappend.
> >>
> >> The git log states: "rp_filter causes issues with VLAN interfaces."
> >>
> >> An email patch for procps from FSL back on 3/7/13 states:
> >>
> >> "disable rp_filter to enhance ASF IP forward performance, which is
> >> really fsl SDK specific."
> >>
> >> Are both of these statements true?
> >>
> >> If so, it looks like AS_FASTPATH is almost always disabled by default
> >> in the powerpc defconfigs.  Therefore, if reverse path filtering
> >> issues are specific to AS_FASTPATH, I suggest RPF shouldn't be disabled by
> default.
> >>    Perhaps add a comment in the drivers/net/Kconfig help for
> >> AS_FASTPATH that if AS_FASTPATH is enabled, then disable RPF.
> >>
> >> Regardless, can we get a description added to this recipe append file to
> >> document why it exists?   And if there is no need to disable RPF in
> >> default configurations, can we just get rid of it?
> >>
> >> Thanks
> >>
> >> Bob
> >>
> >>
> >>
> >>
> >>
> >>
> >> --
> >> _______________________________________________
> >> meta-freescale mailing list
> >> meta-freescale@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-freescale
> >
> 
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: meta-fsl-ppc: questioning reason to disable reverse path filtering...
  2014-12-05  8:22     ` zhenhua.luo
@ 2014-12-07 18:23       ` Bob Cochran
  0 siblings, 0 replies; 6+ messages in thread
From: Bob Cochran @ 2014-12-07 18:23 UTC (permalink / raw)
  To: zhenhua.luo@freescale.com, ting.liu@freescale.com,
	Sandeep.Malik@freescale.com
  Cc: meta-freescale@yoctoproject.org



On 12/05/2014 03:22 AM, zhenhua.luo@freescale.com wrote:
> Since the RP_FILTER options only influence the ASF performance, ASF is disabled by default, so the procps bbappend can be removed to enable the RP_FILTER options by default.
>
> The ASF document needs to be updated to tell users to disable RP_FILTER options when using ASF.


Thank you Ting and Zhenhua for the responses.

It's my understanding that the QorIQ SDK1.7 will soon be out. 
Therefore, I'm not going to submit any additional patches to 
meta-fsl-ppc until I have had a chance to review the new SDK.

Also, I'm expecting that your FSL team will soon be pushing up various 
patches to meta-fsl-ppc to sync with the latest SDK.

During the last community meeting, I took an action item to help with 
meta-fsl-ppc.  I'm planning on doing this in earnest after the SDK 1.7 
release.

Best of luck completing the new SDK.

Bob


>
>
> Best Regards,
>
> Zhenhua
>
>> -----Original Message-----
>> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
>> bounces@yoctoproject.org] On Behalf Of Bob Cochran
>> Sent: Tuesday, December 02, 2014 12:02 PM
>> To: Liu Ting-B28495; Malik Sandeep-B02416
>> Cc: meta-freescale@yoctoproject.org
>> Subject: Re: [meta-freescale] meta-fsl-ppc: questioning reason to disable
>> reverse path filtering...
>>
>> On 12/01/2014 09:38 PM, ting.liu@freescale.com wrote:
>>> Hi Bob,
>>>
>>> You are right. Below is the answer from Sandeep (added in):
>>>
>>> "The RP_FILTER issues are specific to AS_FASTPATH and with current ASF
>> implementation the RP_FILTER needs to be disabled. Since the ASF is disabled
>> by default so the RP_FILTER can be enabled by default and the same can be
>> disabled when someone enables the AS_FASTPATH."
>>>
>>
>>
>> Thank you Ting.  What is the right way to patch this?  Can we remove the
>> procps bbappend and add something to AS_FASTPATH Kconfig help as I had
>> proposed?
>>
>> If not, please propose what you would like to see.
>>
>>
>>> -Ting
>>>
>>>> -----Original Message-----
>>>> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
>>>> bounces@yoctoproject.org] On Behalf Of Bob Cochran
>>>> Sent: Sunday, November 30, 2014 3:06 AM
>>>> To: meta-freescale@yoctoproject.org
>>>> Subject: [meta-freescale] meta-fsl-ppc: questioning reason to disable
>>>> reverse path filtering...
>>>>
>>>> Hi,
>>>>
>>>> Reverse Path filtering (RPF) is disabled by meta-fsl-ppc/recipes-
>>>> extended/procps_%.bbappend.
>>>>
>>>> The git log states: "rp_filter causes issues with VLAN interfaces."
>>>>
>>>> An email patch for procps from FSL back on 3/7/13 states:
>>>>
>>>> "disable rp_filter to enhance ASF IP forward performance, which is
>>>> really fsl SDK specific."
>>>>
>>>> Are both of these statements true?
>>>>
>>>> If so, it looks like AS_FASTPATH is almost always disabled by default
>>>> in the powerpc defconfigs.  Therefore, if reverse path filtering
>>>> issues are specific to AS_FASTPATH, I suggest RPF shouldn't be disabled by
>> default.
>>>>     Perhaps add a comment in the drivers/net/Kconfig help for
>>>> AS_FASTPATH that if AS_FASTPATH is enabled, then disable RPF.
>>>>
>>>> Regardless, can we get a description added to this recipe append file to
>>>> document why it exists?   And if there is no need to disable RPF in
>>>> default configurations, can we just get rid of it?
>>>>
>>>> Thanks
>>>>
>>>> Bob
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> _______________________________________________
>>>> meta-freescale mailing list
>>>> meta-freescale@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/meta-freescale
>>>
>>
>> --
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-12-07 18:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-29 19:06 meta-fsl-ppc: questioning reason to disable reverse path filtering Bob Cochran
2014-11-30  2:44 ` ting.liu
2014-12-02  2:38 ` ting.liu
2014-12-02  4:02   ` Bob Cochran
2014-12-05  8:22     ` zhenhua.luo
2014-12-07 18:23       ` Bob Cochran

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.