All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>
Cc: Michael Neuling <mikey@neuling.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: powerpc: kernel: signal_32.c: Remove unused function
Date: Sun, 07 Dec 2014 23:18:40 +0100	[thread overview]
Message-ID: <5484D240.30506@nod.at> (raw)
In-Reply-To: <1417990021-18696-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

Am 07.12.2014 um 23:07 schrieb Rickard Strandqvist:
> Remove the function sys_debug_setcontext() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.

Please don't blindly trust code analysis tools.
The function you're removing *is* in use.

  LD      init/built-in.o
arch/powerpc/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x744): undefined reference to `sys_debug_setcontext'
make: *** [vmlinux] Error 1

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Michael Neuling <mikey@neuling.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: powerpc: kernel: signal_32.c:  Remove unused function
Date: Sun, 07 Dec 2014 23:18:40 +0100	[thread overview]
Message-ID: <5484D240.30506@nod.at> (raw)
In-Reply-To: <1417990021-18696-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

Am 07.12.2014 um 23:07 schrieb Rickard Strandqvist:
> Remove the function sys_debug_setcontext() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.

Please don't blindly trust code analysis tools.
The function you're removing *is* in use.

  LD      init/built-in.o
arch/powerpc/kernel/built-in.o: In function `sys_call_table':
(.rodata+0x744): undefined reference to `sys_debug_setcontext'
make: *** [vmlinux] Error 1

Thanks,
//richard

  reply	other threads:[~2014-12-07 22:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-07 22:07 [PATCH] arch: powerpc: kernel: signal_32.c: Remove unused function Rickard Strandqvist
2014-12-07 22:07 ` Rickard Strandqvist
2014-12-07 22:18 ` Richard Weinberger [this message]
2014-12-07 22:18   ` Richard Weinberger
2014-12-07 23:11   ` Rickard Strandqvist
2014-12-07 23:11     ` Rickard Strandqvist
2014-12-07 23:15     ` Richard Weinberger
2014-12-07 23:15       ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5484D240.30506@nod.at \
    --to=richard@nod.at \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.