From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4/004: add dump/restore test
Date: Mon, 8 Dec 2014 09:44:48 +0800 [thread overview]
Message-ID: <54850290.2070201@cn.fujitsu.com> (raw)
In-Reply-To: <20141206214040.GA27484@thunk.org>
Hi,
On 12/07/2014 05:40 AM, Theodore Ts'o wrote:
> On Tue, Nov 25, 2014 at 06:21:09PM +0800, Xiaoguang Wang wrote:
>> This test case will first use fsstress to fill a file system, then
>> dump it to standard output and restore it from standard input, finally
>> check that the original contents and the new contents generated by
>> restore tool will be same.
>>
>> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
>
> One question --- what is the intent of this test? Is it to test the
> kernel, or the dump/restore program? I have not bothered putting
> regression tests for e2fsprogs in xfstests, because if I'm developing
> e2fsprogs, it actually makes much more sense to put the regression
> tests in the e2fsprogs git tree.
Yeah, my intent is to test dump/restore program, and indeed I imitate that
how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in
corresponding xfs directory.
Regards,
Xiaoguang Wang
>
> If this is because it's more convenient to put this in xfsprogs
> because it has fsstress, maybe we should adjust the groups that it is
> in so that it's not in auto or quick, but some other group? Or add it
> to some group like "userspace" so I can exclude it when I'm mostly
> interested in testing development kernels?
>
> Thanks,
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: <fstests@vger.kernel.org>, <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4/004: add dump/restore test
Date: Mon, 8 Dec 2014 09:44:48 +0800 [thread overview]
Message-ID: <54850290.2070201@cn.fujitsu.com> (raw)
In-Reply-To: <20141206214040.GA27484@thunk.org>
Hi,
On 12/07/2014 05:40 AM, Theodore Ts'o wrote:
> On Tue, Nov 25, 2014 at 06:21:09PM +0800, Xiaoguang Wang wrote:
>> This test case will first use fsstress to fill a file system, then
>> dump it to standard output and restore it from standard input, finally
>> check that the original contents and the new contents generated by
>> restore tool will be same.
>>
>> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
>
> One question --- what is the intent of this test? Is it to test the
> kernel, or the dump/restore program? I have not bothered putting
> regression tests for e2fsprogs in xfstests, because if I'm developing
> e2fsprogs, it actually makes much more sense to put the regression
> tests in the e2fsprogs git tree.
Yeah, my intent is to test dump/restore program, and indeed I imitate that
how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in
corresponding xfs directory.
Regards,
Xiaoguang Wang
>
> If this is because it's more convenient to put this in xfsprogs
> because it has fsstress, maybe we should adjust the groups that it is
> in so that it's not in auto or quick, but some other group? Or add it
> to some group like "userspace" so I can exclude it when I'm mostly
> interested in testing development kernels?
>
> Thanks,
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-12-08 1:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 10:21 [PATCH] ext4/004: add dump/restore test Xiaoguang Wang
2014-11-25 10:21 ` Xiaoguang Wang
2014-12-01 5:45 ` Dave Chinner
2014-12-03 2:44 ` Xiaoguang Wang
2014-12-03 2:44 ` Xiaoguang Wang
2014-12-03 6:40 ` [PATCH v2] " Xiaoguang Wang
2014-12-03 6:40 ` Xiaoguang Wang
2014-12-03 7:49 ` Eryu Guan
2014-12-03 9:47 ` Xiaoguang Wang
2014-12-03 9:47 ` Xiaoguang Wang
2014-12-04 7:29 ` Eryu Guan
2014-12-05 7:16 ` [PATCH v3] ext4: " Xiaoguang Wang
2014-12-05 7:16 ` Xiaoguang Wang
2014-12-06 21:40 ` [PATCH] ext4/004: " Theodore Ts'o
2014-12-06 23:44 ` Dave Chinner
2014-12-08 1:44 ` Xiaoguang Wang [this message]
2014-12-08 1:44 ` Xiaoguang Wang
2014-12-16 2:58 ` Theodore Ts'o
2014-12-16 3:59 ` Dave Chinner
2014-12-16 15:53 ` Theodore Ts'o
2014-12-16 19:36 ` Dave Chinner
2014-12-17 5:16 ` Xiaoguang Wang
2014-12-17 5:16 ` Xiaoguang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54850290.2070201@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.