* [Qemu-trivial] [PATCH] virtio: remove useless virtio_net_init define
@ 2014-12-08 11:48 ` arei.gonglei
0 siblings, 0 replies; 6+ messages in thread
From: arei.gonglei @ 2014-12-08 11:48 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Gonglei, mst
From: Gonglei <arei.gonglei@huawei.com>
commit 1773d9ee (virtio-net: cleanup: init and exit function)
had removed realization of virtio_net_init(), but didn't remove
the define of head file. Let's remove it.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
include/hw/virtio/virtio.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 0726d76..f24997d 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -230,9 +230,6 @@ int virtio_set_features(VirtIODevice *vdev, uint32_t val);
/* Base devices. */
typedef struct VirtIOBlkConf VirtIOBlkConf;
struct virtio_net_conf;
-VirtIODevice *virtio_net_init(DeviceState *dev, NICConf *conf,
- struct virtio_net_conf *net,
- uint32_t host_features);
typedef struct virtio_serial_conf virtio_serial_conf;
typedef struct VirtIOSCSIConf VirtIOSCSIConf;
typedef struct VirtIORNGConf VirtIORNGConf;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define
@ 2014-12-08 11:48 ` arei.gonglei
0 siblings, 0 replies; 6+ messages in thread
From: arei.gonglei @ 2014-12-08 11:48 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Gonglei, mst
From: Gonglei <arei.gonglei@huawei.com>
commit 1773d9ee (virtio-net: cleanup: init and exit function)
had removed realization of virtio_net_init(), but didn't remove
the define of head file. Let's remove it.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
include/hw/virtio/virtio.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 0726d76..f24997d 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -230,9 +230,6 @@ int virtio_set_features(VirtIODevice *vdev, uint32_t val);
/* Base devices. */
typedef struct VirtIOBlkConf VirtIOBlkConf;
struct virtio_net_conf;
-VirtIODevice *virtio_net_init(DeviceState *dev, NICConf *conf,
- struct virtio_net_conf *net,
- uint32_t host_features);
typedef struct virtio_serial_conf virtio_serial_conf;
typedef struct VirtIOSCSIConf VirtIOSCSIConf;
typedef struct VirtIORNGConf VirtIORNGConf;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define
2014-12-08 11:48 ` [Qemu-devel] " arei.gonglei
@ 2014-12-08 15:34 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2014-12-08 15:34 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-trivial, qemu-devel, mst
<arei.gonglei@huawei.com> writes:
> From: Gonglei <arei.gonglei@huawei.com>
>
> commit 1773d9ee (virtio-net: cleanup: init and exit function)
> had removed realization of virtio_net_init(), but didn't remove
> the define of head file. Let's remove it.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
I get what you mean by "realization", but the technical term is
definition, and the thing you remove is a declaration.
Suggest
virtio: remove useless declaration of virtio_net_init()
Commit 1773d9ee (virtio-net: cleanup: init and exit function)
removed the definition of virtio_net_init(), but didn't remove its
declaration in the header. Clean that up.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define
@ 2014-12-08 15:34 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2014-12-08 15:34 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-trivial, qemu-devel, mst
<arei.gonglei@huawei.com> writes:
> From: Gonglei <arei.gonglei@huawei.com>
>
> commit 1773d9ee (virtio-net: cleanup: init and exit function)
> had removed realization of virtio_net_init(), but didn't remove
> the define of head file. Let's remove it.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
I get what you mean by "realization", but the technical term is
definition, and the thing you remove is a declaration.
Suggest
virtio: remove useless declaration of virtio_net_init()
Commit 1773d9ee (virtio-net: cleanup: init and exit function)
removed the definition of virtio_net_init(), but didn't remove its
declaration in the header. Clean that up.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define
2014-12-08 15:34 ` Markus Armbruster
@ 2014-12-09 1:49 ` Gonglei
-1 siblings, 0 replies; 6+ messages in thread
From: Gonglei @ 2014-12-09 1:49 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
On 2014/12/8 23:34, Markus Armbruster wrote:
> <arei.gonglei@huawei.com> writes:
>
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> commit 1773d9ee (virtio-net: cleanup: init and exit function)
>> had removed realization of virtio_net_init(), but didn't remove
>> the define of head file. Let's remove it.
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>
> I get what you mean by "realization", but the technical term is
> definition, and the thing you remove is a declaration.
>
Thanks for your point. :)
> Suggest
>
> virtio: remove useless declaration of virtio_net_init()
>
> Commit 1773d9ee (virtio-net: cleanup: init and exit function)
> removed the definition of virtio_net_init(), but didn't remove its
> declaration in the header. Clean that up.
OK, will do.
Regards,
-Gonglei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define
@ 2014-12-09 1:49 ` Gonglei
0 siblings, 0 replies; 6+ messages in thread
From: Gonglei @ 2014-12-09 1:49 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
On 2014/12/8 23:34, Markus Armbruster wrote:
> <arei.gonglei@huawei.com> writes:
>
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> commit 1773d9ee (virtio-net: cleanup: init and exit function)
>> had removed realization of virtio_net_init(), but didn't remove
>> the define of head file. Let's remove it.
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>
> I get what you mean by "realization", but the technical term is
> definition, and the thing you remove is a declaration.
>
Thanks for your point. :)
> Suggest
>
> virtio: remove useless declaration of virtio_net_init()
>
> Commit 1773d9ee (virtio-net: cleanup: init and exit function)
> removed the definition of virtio_net_init(), but didn't remove its
> declaration in the header. Clean that up.
OK, will do.
Regards,
-Gonglei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-09 1:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-08 11:48 [Qemu-trivial] [PATCH] virtio: remove useless virtio_net_init define arei.gonglei
2014-12-08 11:48 ` [Qemu-devel] " arei.gonglei
2014-12-08 15:34 ` [Qemu-trivial] " Markus Armbruster
2014-12-08 15:34 ` Markus Armbruster
2014-12-09 1:49 ` [Qemu-trivial] " Gonglei
2014-12-09 1:49 ` Gonglei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.