* [PATCH net-next] sunvnet: fix incorrect rcu_read_unlock() in vnet_start_xmit()
@ 2014-12-09 2:46 David L Stevens
2014-12-09 2:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David L Stevens @ 2014-12-09 2:46 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Sowmini Varadhan, Rashmi Narasimhan
This patch removes an extra rcu_read_unlock() on an allocation failure
in vnet_skb_shape(). The needed rcu_read_unlock() is already done in
the out_dropped label.
Reported-by: Rashmi Narasimhan <rashmi.narasimhan@oracle.com>
Signed-off-by: David L Stevens <david.stevens@oracle.com>
---
drivers/net/ethernet/sun/sunvnet.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
index b883add..36fdf52 100644
--- a/drivers/net/ethernet/sun/sunvnet.c
+++ b/drivers/net/ethernet/sun/sunvnet.c
@@ -1317,10 +1317,8 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
skb = vnet_skb_shape(skb, 2);
- if (unlikely(!skb)) {
- rcu_read_unlock();
+ if (unlikely(!skb))
goto out_dropped;
- }
if (skb->ip_summed == CHECKSUM_PARTIAL)
vnet_fullcsum(skb);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] sunvnet: fix incorrect rcu_read_unlock() in vnet_start_xmit()
2014-12-09 2:46 [PATCH net-next] sunvnet: fix incorrect rcu_read_unlock() in vnet_start_xmit() David L Stevens
@ 2014-12-09 2:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-12-09 2:55 UTC (permalink / raw)
To: david.stevens; +Cc: netdev, sowmini.varadhan, rashmi.narasimhan
From: David L Stevens <david.stevens@oracle.com>
Date: Mon, 08 Dec 2014 21:46:09 -0500
> This patch removes an extra rcu_read_unlock() on an allocation failure
> in vnet_skb_shape(). The needed rcu_read_unlock() is already done in
> the out_dropped label.
>
> Reported-by: Rashmi Narasimhan <rashmi.narasimhan@oracle.com>
> Signed-off-by: David L Stevens <david.stevens@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-09 2:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-09 2:46 [PATCH net-next] sunvnet: fix incorrect rcu_read_unlock() in vnet_start_xmit() David L Stevens
2014-12-09 2:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.