All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neelesh Gupta <neelegup-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org
Subject: Re: [v3] i2c: Driver to expose PowerNV platform i2c busses
Date: Tue, 09 Dec 2014 18:48:40 +0530	[thread overview]
Message-ID: <5486F6B0.4030302@linux.vnet.ibm.com> (raw)
In-Reply-To: <20141209094503.100F81400DE-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>


On 12/09/2014 03:15 PM, Michael Ellerman wrote:
> On Mon, 2014-08-12 at 06:36:16 UTC, Neelesh Gupta wrote:
>> The patch exposes the available i2c busses on the PowerNV platform
>> to the kernel and implements the bus driver to support i2c and
>> smbus commands.
>> The driver uses the platform device infrastructure to probe the busses
>> on the platform and registers them with the i2c driver framework.
>>   arch/powerpc/include/asm/opal.h                    |   29 ++
>>   arch/powerpc/platforms/powernv/opal-wrappers.S     |    1
>>   arch/powerpc/platforms/powernv/opal.c              |   11 +
> This had major conflicts in the above files.
>
> I've fixed it up but please check I did it correctly:
>
>    https://github.com/mpe/powerpc-merge/commits/pw/neelesh-i2c
>
> It also doesn't build as a module:
>
>    $ grep CONFIG_I2C_OPAL .config
>    CONFIG_I2C_OPAL=m
>    $ make ...
>    ...
>    ERROR: "opal_i2c_request" [drivers/i2c/busses/i2c-opal.ko] undefined!

Yeah, this needs to be exported.
I think for the same reason, "opal-rtc" is still waiting, plus awaiting 
"ack" from
maintainers.

- Neelesh

>
> cheers
>

WARNING: multiple messages have this Message-ID (diff)
From: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@ozlabs.org, devicetree@vger.kernel.org,
	linux-i2c@vger.kernel.org, wsa@the-dreams.de
Subject: Re: [v3] i2c: Driver to expose PowerNV platform i2c busses
Date: Tue, 09 Dec 2014 18:48:40 +0530	[thread overview]
Message-ID: <5486F6B0.4030302@linux.vnet.ibm.com> (raw)
In-Reply-To: <20141209094503.100F81400DE@ozlabs.org>


On 12/09/2014 03:15 PM, Michael Ellerman wrote:
> On Mon, 2014-08-12 at 06:36:16 UTC, Neelesh Gupta wrote:
>> The patch exposes the available i2c busses on the PowerNV platform
>> to the kernel and implements the bus driver to support i2c and
>> smbus commands.
>> The driver uses the platform device infrastructure to probe the busses
>> on the platform and registers them with the i2c driver framework.
>>   arch/powerpc/include/asm/opal.h                    |   29 ++
>>   arch/powerpc/platforms/powernv/opal-wrappers.S     |    1
>>   arch/powerpc/platforms/powernv/opal.c              |   11 +
> This had major conflicts in the above files.
>
> I've fixed it up but please check I did it correctly:
>
>    https://github.com/mpe/powerpc-merge/commits/pw/neelesh-i2c
>
> It also doesn't build as a module:
>
>    $ grep CONFIG_I2C_OPAL .config
>    CONFIG_I2C_OPAL=m
>    $ make ...
>    ...
>    ERROR: "opal_i2c_request" [drivers/i2c/busses/i2c-opal.ko] undefined!

Yeah, this needs to be exported.
I think for the same reason, "opal-rtc" is still waiting, plus awaiting 
"ack" from
maintainers.

- Neelesh

>
> cheers
>

  parent reply	other threads:[~2014-12-09 13:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08  6:36 [PATCH v3] i2c: Driver to expose PowerNV platform i2c busses Neelesh Gupta
2014-12-08  6:36 ` Neelesh Gupta
     [not found] ` <20141208063039.14356.34770.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-08 20:13   ` Benjamin Herrenschmidt
2014-12-08 20:13     ` Benjamin Herrenschmidt
     [not found]     ` <1418069595.4827.43.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2014-12-08 20:55       ` Wolfram Sang
2014-12-08 20:55         ` Wolfram Sang
2014-12-08 21:43         ` Benjamin Herrenschmidt
2014-12-08 21:43           ` Benjamin Herrenschmidt
     [not found]           ` <1418075026.13358.4.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2014-12-09  8:54             ` Wolfram Sang
2014-12-09  8:54               ` Wolfram Sang
2014-12-09  9:43               ` Benjamin Herrenschmidt
2014-12-09  9:43                 ` Benjamin Herrenschmidt
2014-12-09  9:45   ` [v3] " Michael Ellerman
2014-12-09  9:45     ` Michael Ellerman
     [not found]     ` <20141209094503.100F81400DE-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
2014-12-09 10:21       ` Benjamin Herrenschmidt
2014-12-09 10:21         ` Benjamin Herrenschmidt
     [not found]         ` <1418120492.13358.45.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2014-12-12  5:30           ` Michael Ellerman
2014-12-12  5:30             ` Michael Ellerman
2014-12-09 13:18       ` Neelesh Gupta [this message]
2014-12-09 13:18         ` Neelesh Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5486F6B0.4030302@linux.vnet.ibm.com \
    --to=neelegup-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.