All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
	ming.lei@canonical.com, armbru@redhat.com, mreitz@redhat.com,
	stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH V2 1/4] block: add accounting for merged requests
Date: Tue, 09 Dec 2014 16:43:30 +0100	[thread overview]
Message-ID: <548718A2.5030002@kamp.de> (raw)
In-Reply-To: <5481C830.2060403@redhat.com>

On 05.12.2014 15:58, Eric Blake wrote:
> On 12/05/2014 04:50 AM, Peter Lieven wrote:
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>>   block.c                    |    2 ++
>>   block/accounting.c         |    7 +++++++
>>   block/qapi.c               |    2 ++
>>   hmp.c                      |    6 +++++-
>>   include/block/accounting.h |    3 +++
>>   qapi/block-core.json       |    9 ++++++++-
>>   qmp-commands.hx            |   22 ++++++++++++++++++----
>>   7 files changed, 45 insertions(+), 6 deletions(-)
>> @@ -2284,6 +2288,8 @@ Example:
>>                     "rd_total_times_ns":3465673657
>>                     "flush_total_times_ns":49653
>>                     "flush_operations":61,
>> +                  "rd_merged":0,
>> +                  "wr_merged":0
> Oh my - we previously had invalid JSON in our example.  Yay that this
> fixes it :)

There is actually more invalid JSON, but I would fix that in a separate
patch apart from this series.

Peter

  reply	other threads:[~2014-12-09 15:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 11:50 [Qemu-devel] [RFC PATCH V2 0/4] virtio-blk: add multiread support Peter Lieven
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 1/4] block: add accounting for merged requests Peter Lieven
2014-12-05 14:58   ` Eric Blake
2014-12-09 15:43     ` Peter Lieven [this message]
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 2/4] hw/virtio-blk: add a constant for max number of " Peter Lieven
2014-12-05 14:59   ` Eric Blake
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 3/4] block-backend: expose bs->bl.max_transfer_length Peter Lieven
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 4/4] virtio-blk: introduce multiread Peter Lieven
2014-12-05 15:05   ` Eric Blake
2014-12-09 15:44     ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548718A2.5030002@kamp.de \
    --to=pl@kamp.de \
    --cc=armbru@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ming.lei@canonical.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.