From: Larry Finger <Larry.Finger@lwfinger.net>
To: weiyj_lk@163.com, Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Ben Hutchings <ben@decadent.org.uk>,
Peter Wu <lekensteyn@gmail.com>,
Karsten Wiese <fzuuzf@googlemail.com>,
Andy Spencer <andy753421@ucla.edu>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning
Date: Tue, 09 Dec 2014 11:21:00 -0600 [thread overview]
Message-ID: <54872F7C.5080405@lwfinger.net> (raw)
In-Reply-To: <1418131123-3606-1-git-send-email-weiyj_lk@163.com>
On 12/09/2014 07:18 AM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
There is only one warning.
>
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c:1595:6: warning:
> symbol 'usb_cmd_send_packet' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Changing usb_cmd_send_packet() to be static is correct.
@john: If you want to deal with fixing the commit message, then please add
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index 873363ac..5513217 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1592,7 +1592,7 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> }
> }
>
> -bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> +static bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> {
> /* Currently nothing happens here.
> * Traffic stops after some seconds in WPA2 802.11n mode.
>
>
prev parent reply other threads:[~2014-12-09 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 13:18 [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning weiyj_lk
2014-12-09 17:21 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54872F7C.5080405@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andy753421@ucla.edu \
--cc=ben@decadent.org.uk \
--cc=chaoming_li@realsil.com.cn \
--cc=fzuuzf@googlemail.com \
--cc=lekensteyn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.