* [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning
@ 2014-12-09 13:18 weiyj_lk
2014-12-09 17:21 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2014-12-09 13:18 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, John W. Linville, Mark Cave-Ayland,
Rickard Strandqvist, Ben Hutchings, Peter Wu, Karsten Wiese,
Andy Spencer
Cc: Wei Yongjun, linux-wireless
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warnings:
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c:1595:6: warning:
symbol 'usb_cmd_send_packet' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index 873363ac..5513217 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -1592,7 +1592,7 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
}
}
-bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
+static bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
{
/* Currently nothing happens here.
* Traffic stops after some seconds in WPA2 802.11n mode.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning
2014-12-09 13:18 [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning weiyj_lk
@ 2014-12-09 17:21 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2014-12-09 17:21 UTC (permalink / raw)
To: weiyj_lk, Chaoming Li, John W. Linville, Mark Cave-Ayland,
Rickard Strandqvist, Ben Hutchings, Peter Wu, Karsten Wiese,
Andy Spencer
Cc: Wei Yongjun, linux-wireless
On 12/09/2014 07:18 AM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
There is only one warning.
>
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c:1595:6: warning:
> symbol 'usb_cmd_send_packet' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Changing usb_cmd_send_packet() to be static is correct.
@john: If you want to deal with fixing the commit message, then please add
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index 873363ac..5513217 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1592,7 +1592,7 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> }
> }
>
> -bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> +static bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> {
> /* Currently nothing happens here.
> * Traffic stops after some seconds in WPA2 802.11n mode.
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-09 17:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-09 13:18 [PATCH -next] rtlwifi: rtl8192cu: Fix sparse non static symbol warning weiyj_lk
2014-12-09 17:21 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.