From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: linux-next: build failure after merge of the access_once tree
Date: Tue, 09 Dec 2014 20:54:27 +0100 [thread overview]
Message-ID: <54875373.50305@de.ibm.com> (raw)
In-Reply-To: <20141208222641.40a64946@canb.auug.org.au>
Am 08.12.2014 um 12:26 schrieb Stephen Rothwell:
> Hi Christian,
>
> After merging the acess_once tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
>
> arch/powerpc/mm/hugetlbpage.c: In function 'find_linux_pte_or_hugepte':
> arch/powerpc/mm/hugetlbpage.c:981:3: error: invalid initializer
> pud = ACCESS_ONCE(*pudp);
> ^
> arch/powerpc/mm/hugetlbpage.c:993:4: error: invalid initializer
> pmd = ACCESS_ONCE(*pmdp);
> ^
>
> These are preexisting ...
>
> mm/gup.c: In function 'gup_pmd_range':
> mm/gup.c:929:3: error: invalid initializer
> pmd_t pmd = ACCESS_ONCE(*pmdp);
> ^
> mm/gup.c:929:3: error: (near initialization for 'pmd')
>
> This is from commit f30c59e921f1 ("mm: Update generic gup
> implementation to handle hugepage directory") from the powerpc-mpe (and
> powerpc) tree and so will require a merge fix patch (presumable
> s/ACCESS_ONCE/READ_ONCE/).
>
> I am not sure how many architectures you are trying to cover, but
> powerpc is one I care about :-)
>
> I have dropped the access_once tree again today, sorry (its too late at
> night).
>
Next try. I removed the change of ACCESS_ONCE and just left the new interfaces and the simple reworks in the queue.
I will tackle everything else after rc1 when next should be small again. Keeping fingers crossed....
Christian
next prev parent reply other threads:[~2014-12-09 19:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 11:26 linux-next: build failure after merge of the access_once tree Stephen Rothwell
2014-12-08 11:26 ` Stephen Rothwell
2014-12-08 11:35 ` Christian Borntraeger
2014-12-08 11:35 ` Christian Borntraeger
2014-12-09 19:54 ` Christian Borntraeger [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-10 8:20 Stephen Rothwell
2014-12-10 11:20 ` Christian Borntraeger
2014-12-05 10:32 Stephen Rothwell
2014-12-07 20:57 ` Christian Borntraeger
2014-12-07 21:16 ` Christian Borntraeger
2014-12-07 23:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54875373.50305@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.