* [Qemu-trivial] [PATCH] fw_cfg: remove superfluous blank line
@ 2014-12-08 11:52 ` arei.gonglei
0 siblings, 0 replies; 4+ messages in thread
From: arei.gonglei @ 2014-12-08 11:52 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, Gonglei
From: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hw/nvram/fw_cfg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index a7122ee..c4b78ed 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -621,7 +621,6 @@ static void fw_cfg_realize(DeviceState *dev, Error **errp)
FWCfgState *s = FW_CFG(dev);
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
-
if (s->ctl_iobase + 1 == s->data_iobase) {
sysbus_add_io(sbd, s->ctl_iobase, &s->comb_iomem);
} else {
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] fw_cfg: remove superfluous blank line
@ 2014-12-08 11:52 ` arei.gonglei
0 siblings, 0 replies; 4+ messages in thread
From: arei.gonglei @ 2014-12-08 11:52 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, Gonglei
From: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hw/nvram/fw_cfg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index a7122ee..c4b78ed 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -621,7 +621,6 @@ static void fw_cfg_realize(DeviceState *dev, Error **errp)
FWCfgState *s = FW_CFG(dev);
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
-
if (s->ctl_iobase + 1 == s->data_iobase) {
sysbus_add_io(sbd, s->ctl_iobase, &s->comb_iomem);
} else {
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [PATCH] fw_cfg: remove superfluous blank line
2014-12-08 11:52 ` [Qemu-devel] " arei.gonglei
@ 2014-12-10 8:50 ` Michael Tokarev
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-12-10 8:50 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: qemu-trivial, pbonzini
Applied to trivial.
However, I think this patch is too trivial even
for trivial-patches queue... ;) As in, don't
bother fixing things like this unless there's
other code around being changed too.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] fw_cfg: remove superfluous blank line
@ 2014-12-10 8:50 ` Michael Tokarev
0 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-12-10 8:50 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: qemu-trivial, pbonzini
Applied to trivial.
However, I think this patch is too trivial even
for trivial-patches queue... ;) As in, don't
bother fixing things like this unless there's
other code around being changed too.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-10 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-08 11:52 [Qemu-trivial] [PATCH] fw_cfg: remove superfluous blank line arei.gonglei
2014-12-08 11:52 ` [Qemu-devel] " arei.gonglei
2014-12-10 8:50 ` [Qemu-trivial] " Michael Tokarev
2014-12-10 8:50 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.