* [Qemu-trivial] [PATCH v2] virtio: remove useless declaration of virtio_net_init()
@ 2014-12-09 2:09 ` arei.gonglei
0 siblings, 0 replies; 6+ messages in thread
From: arei.gonglei @ 2014-12-09 2:09 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Gonglei, Markus Armbruster, mst
From: Gonglei <arei.gonglei@huawei.com>
commit 1773d9ee (virtio-net: cleanup: init and exit function)
removed the definition of virtio_net_init(), but didn't remove its
declaration in the header. Clean that up.
Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
v2:
update the patch's tilte and commit message as suggested by Markus.
---
include/hw/virtio/virtio.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 0726d76..f24997d 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -230,9 +230,6 @@ int virtio_set_features(VirtIODevice *vdev, uint32_t val);
/* Base devices. */
typedef struct VirtIOBlkConf VirtIOBlkConf;
struct virtio_net_conf;
-VirtIODevice *virtio_net_init(DeviceState *dev, NICConf *conf,
- struct virtio_net_conf *net,
- uint32_t host_features);
typedef struct virtio_serial_conf virtio_serial_conf;
typedef struct VirtIOSCSIConf VirtIOSCSIConf;
typedef struct VirtIORNGConf VirtIORNGConf;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH v2] virtio: remove useless declaration of virtio_net_init()
@ 2014-12-09 2:09 ` arei.gonglei
0 siblings, 0 replies; 6+ messages in thread
From: arei.gonglei @ 2014-12-09 2:09 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Gonglei, Markus Armbruster, mst
From: Gonglei <arei.gonglei@huawei.com>
commit 1773d9ee (virtio-net: cleanup: init and exit function)
removed the definition of virtio_net_init(), but didn't remove its
declaration in the header. Clean that up.
Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
v2:
update the patch's tilte and commit message as suggested by Markus.
---
include/hw/virtio/virtio.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 0726d76..f24997d 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -230,9 +230,6 @@ int virtio_set_features(VirtIODevice *vdev, uint32_t val);
/* Base devices. */
typedef struct VirtIOBlkConf VirtIOBlkConf;
struct virtio_net_conf;
-VirtIODevice *virtio_net_init(DeviceState *dev, NICConf *conf,
- struct virtio_net_conf *net,
- uint32_t host_features);
typedef struct virtio_serial_conf virtio_serial_conf;
typedef struct VirtIOSCSIConf VirtIOSCSIConf;
typedef struct VirtIORNGConf VirtIORNGConf;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] virtio: remove useless declaration of virtio_net_init()
2014-12-09 2:09 ` [Qemu-devel] " arei.gonglei
@ 2014-12-09 9:34 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2014-12-09 9:34 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-trivial, qemu-devel, mst
<arei.gonglei@huawei.com> writes:
> From: Gonglei <arei.gonglei@huawei.com>
>
> commit 1773d9ee (virtio-net: cleanup: init and exit function)
> removed the definition of virtio_net_init(), but didn't remove its
> declaration in the header. Clean that up.
>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2] virtio: remove useless declaration of virtio_net_init()
@ 2014-12-09 9:34 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2014-12-09 9:34 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-trivial, qemu-devel, mst
<arei.gonglei@huawei.com> writes:
> From: Gonglei <arei.gonglei@huawei.com>
>
> commit 1773d9ee (virtio-net: cleanup: init and exit function)
> removed the definition of virtio_net_init(), but didn't remove its
> declaration in the header. Clean that up.
>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH v2] virtio: remove useless declaration of virtio_net_init()
2014-12-09 2:09 ` [Qemu-devel] " arei.gonglei
@ 2014-12-10 8:52 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2014-12-10 8:52 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: qemu-trivial, Markus Armbruster, mst
applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] virtio: remove useless declaration of virtio_net_init()
@ 2014-12-10 8:52 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2014-12-10 8:52 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: qemu-trivial, Markus Armbruster, mst
applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-10 8:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-09 2:09 [Qemu-trivial] [PATCH v2] virtio: remove useless declaration of virtio_net_init() arei.gonglei
2014-12-09 2:09 ` [Qemu-devel] " arei.gonglei
2014-12-09 9:34 ` [Qemu-trivial] " Markus Armbruster
2014-12-09 9:34 ` Markus Armbruster
2014-12-10 8:52 ` [Qemu-trivial] " Michael Tokarev
2014-12-10 8:52 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.