All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Antony Pavlov <antonynpavlov@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category
Date: Wed, 10 Dec 2014 12:11:18 +0300	[thread overview]
Message-ID: <54880E36.9080701@msgid.tls.msk.ru> (raw)
In-Reply-To: <1417976445-18860-1-git-send-email-antonynpavlov@gmail.com>

07.12.2014 21:20, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  hw/block/pflash_cfi02.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index 8513a17..389b4aa 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data)
>  
>      dc->realize = pflash_cfi02_realize;
>      dc->props = pflash_cfi02_properties;
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>  }
>  
>  static const TypeInfo pflash_cfi02_info = {

Hm.  While the patch itself is trivial, and it _seems_ it
fixes a bug, I'm not sure of possible effects of this.

What prob it has now, does this device work?  If yes,
why it needs fixing?  Do we care about compatibility
with previous versions, about migration?

Cc'ing block device people...

Thanks,

/mjt



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Antony Pavlov <antonynpavlov@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category
Date: Wed, 10 Dec 2014 12:11:18 +0300	[thread overview]
Message-ID: <54880E36.9080701@msgid.tls.msk.ru> (raw)
In-Reply-To: <1417976445-18860-1-git-send-email-antonynpavlov@gmail.com>

07.12.2014 21:20, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  hw/block/pflash_cfi02.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index 8513a17..389b4aa 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data)
>  
>      dc->realize = pflash_cfi02_realize;
>      dc->props = pflash_cfi02_properties;
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>  }
>  
>  static const TypeInfo pflash_cfi02_info = {

Hm.  While the patch itself is trivial, and it _seems_ it
fixes a bug, I'm not sure of possible effects of this.

What prob it has now, does this device work?  If yes,
why it needs fixing?  Do we care about compatibility
with previous versions, about migration?

Cc'ing block device people...

Thanks,

/mjt

  reply	other threads:[~2014-12-10  9:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-07 18:20 [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category Antony Pavlov
2014-12-07 18:20 ` [Qemu-devel] " Antony Pavlov
2014-12-10  9:11 ` Michael Tokarev [this message]
2014-12-10  9:11   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-12-10  9:52   ` Paolo Bonzini
2014-12-10  9:52     ` [Qemu-devel] " Paolo Bonzini
2014-12-10 11:29 ` Michael Tokarev
2014-12-10 11:29   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54880E36.9080701@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=antonynpavlov@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.