From: Eric Blake <eblake@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [QEMU patch 2/2] kvm: allow configuration of tsc deadline timer advancement
Date: Wed, 10 Dec 2014 10:06:28 -0700 [thread overview]
Message-ID: <54887D94.2050501@redhat.com> (raw)
In-Reply-To: <20141210162420.218207164@amt.cnet>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On 12/10/2014 09:23 AM, Marcelo Tosatti wrote:
> Add machine option and QMP commands to configure TSC deadline
> timer advancement.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> ---
> +##
> +# @get-lapic-tscdeadline-advance
> +#
> +# This command gets the TSC deadline timer advancement.
> +#
> +# Only supported by KVM acceleration.
> +#
> +# Since: 2.3
> +##
> +{ 'command': 'get-lapic-tscdeadline-advance', 'returns': 'int' }
Please don't return a bare int. It is not extensible, if we ever need
multiple named values associated with lapic in the future. Return a
dictionary instead.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
prev parent reply other threads:[~2014-12-10 17:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 16:23 [QEMU patch 0/2] QEMU lapic tsc deadline advancement Marcelo Tosatti
2014-12-10 16:23 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 16:23 ` [QEMU patch 1/2] kvm: sync kernel headers Marcelo Tosatti
2014-12-10 16:23 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 16:23 ` [QEMU patch 2/2] kvm: allow configuration of tsc deadline timer advancement Marcelo Tosatti
2014-12-10 16:23 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:01 ` Paolo Bonzini
2014-12-10 17:01 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:04 ` Marcelo Tosatti
2014-12-10 17:04 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:09 ` Paolo Bonzini
2014-12-10 17:09 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:27 ` Marcelo Tosatti
2014-12-10 17:27 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:29 ` Paolo Bonzini
2014-12-10 17:29 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:35 ` Marcelo Tosatti
2014-12-10 17:35 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:55 ` Paolo Bonzini
2014-12-10 17:55 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 18:39 ` Radim Krčmář
2014-12-10 18:39 ` [Qemu-devel] " Radim Krčmář
2014-12-10 18:59 ` Paolo Bonzini
2014-12-10 18:59 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:06 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54887D94.2050501@redhat.com \
--to=eblake@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.