From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
Luiz Capitulino <lcapitulino@redhat.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [QEMU patch 2/2] kvm: allow configuration of tsc deadline timer advancement
Date: Wed, 10 Dec 2014 18:55:56 +0100 [thread overview]
Message-ID: <5488892C.7010606@redhat.com> (raw)
In-Reply-To: <20141210173554.GB21295@amt.cnet>
On 10/12/2014 18:35, Marcelo Tosatti wrote:
> On Wed, Dec 10, 2014 at 06:29:43PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 10/12/2014 18:27, Marcelo Tosatti wrote:
>>> On Wed, Dec 10, 2014 at 06:09:19PM +0100, Paolo Bonzini wrote:
>>>>
>>>>
>>>> On 10/12/2014 18:04, Marcelo Tosatti wrote:
>>>>>> Please add an object property to the x86 CPU object. It can then be
>>>>>> configured with "-global" on the command line.
>>>>>
>>>>> Don't want to allow individual values for different CPUs.
>>>>> It is a per-VM property.
>>>>
>>>> Why? It can cause busy waiting, it would make sense to make it stricter
>>>> for realtime CPUs and leave 0 for non-realtime CPUs.
>>>
>>> HW timer behaviour should be consistent across CPUs, IMO.
>>
>> It's not going to be anyway. Cache line bounces, frequency scaling,
>> presence of higher-priority RT tasks, etc. can cause different response
>> for one CPU over the others.
>
> OK i'll change it to per-CPU.
Well, my preferred choice would be automatic adjustment with a module
parameter. If we need manual tuning, per-CPU would be my choice, but
automatic is nicer anyway. :)
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [QEMU patch 2/2] kvm: allow configuration of tsc deadline timer advancement
Date: Wed, 10 Dec 2014 18:55:56 +0100 [thread overview]
Message-ID: <5488892C.7010606@redhat.com> (raw)
In-Reply-To: <20141210173554.GB21295@amt.cnet>
On 10/12/2014 18:35, Marcelo Tosatti wrote:
> On Wed, Dec 10, 2014 at 06:29:43PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 10/12/2014 18:27, Marcelo Tosatti wrote:
>>> On Wed, Dec 10, 2014 at 06:09:19PM +0100, Paolo Bonzini wrote:
>>>>
>>>>
>>>> On 10/12/2014 18:04, Marcelo Tosatti wrote:
>>>>>> Please add an object property to the x86 CPU object. It can then be
>>>>>> configured with "-global" on the command line.
>>>>>
>>>>> Don't want to allow individual values for different CPUs.
>>>>> It is a per-VM property.
>>>>
>>>> Why? It can cause busy waiting, it would make sense to make it stricter
>>>> for realtime CPUs and leave 0 for non-realtime CPUs.
>>>
>>> HW timer behaviour should be consistent across CPUs, IMO.
>>
>> It's not going to be anyway. Cache line bounces, frequency scaling,
>> presence of higher-priority RT tasks, etc. can cause different response
>> for one CPU over the others.
>
> OK i'll change it to per-CPU.
Well, my preferred choice would be automatic adjustment with a module
parameter. If we need manual tuning, per-CPU would be my choice, but
automatic is nicer anyway. :)
Paolo
next prev parent reply other threads:[~2014-12-10 17:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 16:23 [QEMU patch 0/2] QEMU lapic tsc deadline advancement Marcelo Tosatti
2014-12-10 16:23 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 16:23 ` [QEMU patch 1/2] kvm: sync kernel headers Marcelo Tosatti
2014-12-10 16:23 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 16:23 ` [QEMU patch 2/2] kvm: allow configuration of tsc deadline timer advancement Marcelo Tosatti
2014-12-10 16:23 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:01 ` Paolo Bonzini
2014-12-10 17:01 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:04 ` Marcelo Tosatti
2014-12-10 17:04 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:09 ` Paolo Bonzini
2014-12-10 17:09 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:27 ` Marcelo Tosatti
2014-12-10 17:27 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:29 ` Paolo Bonzini
2014-12-10 17:29 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:35 ` Marcelo Tosatti
2014-12-10 17:35 ` [Qemu-devel] " Marcelo Tosatti
2014-12-10 17:55 ` Paolo Bonzini [this message]
2014-12-10 17:55 ` Paolo Bonzini
2014-12-10 18:39 ` Radim Krčmář
2014-12-10 18:39 ` [Qemu-devel] " Radim Krčmář
2014-12-10 18:59 ` Paolo Bonzini
2014-12-10 18:59 ` [Qemu-devel] " Paolo Bonzini
2014-12-10 17:06 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5488892C.7010606@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.