From: Leon Alrae <leon.alrae@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Use local float status pointer across MSA macros
Date: Thu, 11 Dec 2014 15:37:14 +0000 [thread overview]
Message-ID: <5489BA2A.9080306@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1412021739260.19155@tp.orcam.me.uk>
On 02/12/2014 17:51, Maciej W. Rozycki wrote:
> Reduce line wrapping throughout MSA helper macros by using a local float
> status pointer rather than referring to the float status through the
> environment each time. No functional change.
>
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> Hi,
>
> The same float status applies across a single MSA operation (i.e. there
> can't be an MT thread context switch in the middle) so there is no need
> to get through the environment on each individual sub-operation. And at
> any reasonable optimisation level code generated should be the same if
> not better. The local pointer will help with a follow-up change that
> would otherwise make line wrapping unbearable.
>
> Please apply,
>
> Maciej
>
> qemu-mips-msa-helper-status.diff
> Index: qemu-git-trunk/target-mips/msa_helper.c
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
prev parent reply other threads:[~2014-12-11 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 17:51 [Qemu-devel] [PATCH] target-mips: Use local float status pointer across MSA macros Maciej W. Rozycki
2014-12-11 15:37 ` Leon Alrae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5489BA2A.9080306@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=macro@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.