* [PATCH] radio-settings: Show all available technologies
@ 2014-12-12 11:25 Alfonso Sanchez-Beato
2014-12-12 14:55 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Alfonso Sanchez-Beato @ 2014-12-12 11:25 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
Not all possible futures technologies were being showed on the DBus
interface.
---
src/radio-settings.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/radio-settings.c b/src/radio-settings.c
index 0a49305..1a511dc 100644
--- a/src/radio-settings.c
+++ b/src/radio-settings.c
@@ -225,12 +225,12 @@ static DBusMessage *radio_get_properties_reply(DBusMessage *msg,
}
if (rs->available_rats) {
- const char *rats[sizeof(uint32_t) + 1];
+ const char *rats[sizeof(uint32_t) * CHAR_BIT + 1];
const char **dbus_rats = rats;
int n = 0;
unsigned int i;
- for (i = 0; i < sizeof(uint32_t); i++) {
+ for (i = 0; i < sizeof(uint32_t) * CHAR_BIT; i++) {
int tech = 1 << i;
if (!(rs->available_rats & tech))
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] radio-settings: Show all available technologies
2014-12-12 11:25 [PATCH] radio-settings: Show all available technologies Alfonso Sanchez-Beato
@ 2014-12-12 14:55 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2014-12-12 14:55 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
Hi Alfonso,
On 12/12/2014 05:25 AM, Alfonso Sanchez-Beato wrote:
> Not all possible futures technologies were being showed on the DBus
> interface.
> ---
> src/radio-settings.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Good catch.
Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-12 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-12 11:25 [PATCH] radio-settings: Show all available technologies Alfonso Sanchez-Beato
2014-12-12 14:55 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.