From: Leon Alrae <leon.alrae@imgtec.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/4] disas/mips: remove unused mips16_to_32_reg_map[]
Date: Fri, 12 Dec 2014 16:48:04 +0000 [thread overview]
Message-ID: <548B1C44.8010006@imgtec.com> (raw)
In-Reply-To: <CAFEAcA_+A9KEfeVTiFFuQmH3GE71m2sxmhRydNKzn+kozsm5YQ@mail.gmail.com>
On 12/12/2014 15:53, Peter Maydell wrote:
> On 12 December 2014 at 15:52, Leon Alrae <leon.alrae@imgtec.com> wrote:
>> On 12/12/2014 14:51, Peter Maydell wrote:
>>> Failing that, the best source for a mips16 disassembler is
>>> going to be "fix the bugs in the currently disabled code we
>>> have in the tree", in which case deleting it all would be
>>> a backwards step...
>>
>> Agreed. It may have greater value than I thought. I'll leave it then.
>
> You can silence the warning by sticking #if 0 round
> the offending data (which is probably why the code has the
> #if 0).
Done in v2 of this patch.
Thanks,
Leon
next prev parent reply other threads:[~2014-12-12 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 9:29 [Qemu-devel] [PATCH 0/4] target-mips: fix warnings reported by clang Leon Alrae
2014-12-12 9:30 ` [Qemu-devel] [PATCH 1/4] target-mips: convert single case switch into if statement Leon Alrae
2014-12-12 12:25 ` Peter Maydell
2014-12-12 9:30 ` [Qemu-devel] [PATCH 2/4] disas/mips: remove unused mips_msa_control_names_numeric[32] Leon Alrae
2014-12-12 12:26 ` Peter Maydell
2014-12-12 9:30 ` [Qemu-devel] [PATCH 3/4] disas/mips: remove unused mips16_to_32_reg_map[] Leon Alrae
2014-12-12 12:25 ` Peter Maydell
2014-12-12 14:28 ` Leon Alrae
2014-12-12 14:51 ` Peter Maydell
2014-12-12 15:52 ` Leon Alrae
2014-12-12 15:53 ` Peter Maydell
2014-12-12 16:48 ` Leon Alrae [this message]
2014-12-12 9:30 ` [Qemu-devel] [PATCH 4/4] target-mips: remove excp_names[] from linux-user as it is unused Leon Alrae
2014-12-12 12:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548B1C44.8010006@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.