From: Leon Alrae <leon.alrae@imgtec.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/4] disas/mips: remove unused mips16_to_32_reg_map[]
Date: Fri, 12 Dec 2014 14:28:36 +0000 [thread overview]
Message-ID: <548AFB94.3070800@imgtec.com> (raw)
In-Reply-To: <CAFEAcA8M=1pt4RypDx7YXVZ1--hhdqyj1mviW0mK5+szmGBSUg@mail.gmail.com>
On 12/12/2014 12:25, Peter Maydell wrote:
> On 12 December 2014 at 09:30, Leon Alrae <leon.alrae@imgtec.com> wrote:
>> The array was "used" in a block of code which has never been enabled. Therefore
>> removing the array as well as 700 lines of never used code.
>
> That's quite a lot to remove -- are you sure we're never going to want
> to disassemble mips16 insns in future?
I quickly tried to enable it but it doesn't seem to be complete. For
example it requires "extern const struct mips_opcode mips16_opcodes[]"
which isn't anywhere in the codebase. Moreover, according to the git
blame it has always been disabled since 2005 thus in my opinion there is
no point in keeping this code. I do want to disassemble mips16 insns, if
someone has proper implementation I'm more than happy to include it.
Regards,
Leon
next prev parent reply other threads:[~2014-12-12 14:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 9:29 [Qemu-devel] [PATCH 0/4] target-mips: fix warnings reported by clang Leon Alrae
2014-12-12 9:30 ` [Qemu-devel] [PATCH 1/4] target-mips: convert single case switch into if statement Leon Alrae
2014-12-12 12:25 ` Peter Maydell
2014-12-12 9:30 ` [Qemu-devel] [PATCH 2/4] disas/mips: remove unused mips_msa_control_names_numeric[32] Leon Alrae
2014-12-12 12:26 ` Peter Maydell
2014-12-12 9:30 ` [Qemu-devel] [PATCH 3/4] disas/mips: remove unused mips16_to_32_reg_map[] Leon Alrae
2014-12-12 12:25 ` Peter Maydell
2014-12-12 14:28 ` Leon Alrae [this message]
2014-12-12 14:51 ` Peter Maydell
2014-12-12 15:52 ` Leon Alrae
2014-12-12 15:53 ` Peter Maydell
2014-12-12 16:48 ` Leon Alrae
2014-12-12 9:30 ` [Qemu-devel] [PATCH 4/4] target-mips: remove excp_names[] from linux-user as it is unused Leon Alrae
2014-12-12 12:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548AFB94.3070800@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.