From: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>,
Ashley Lai <ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org>,
Marcel Selhorst <tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org,
christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Will Arthur
<will.c.arthur-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v10 8/8] tpm: TPM 2.0 FIFO Interface
Date: Sun, 14 Dec 2014 09:48:26 -0500 [thread overview]
Message-ID: <548DA33A.4010300@linux.vnet.ibm.com> (raw)
In-Reply-To: <1418413600-5400-9-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
> Detect TPM 2.0 by sending idempotent TPM 2.x command. Ordinals for
> TPM 2.0 are higher than TPM 1.x commands so this should be fail-safe.
> Using STS3 is unreliable because some chips just report 0xff and not
> what the spec says.
TPM TIS 1.2 can report either 0xff or 0x00 for sts3 since that part of
register was not defined for this version but only for a later version.
So, unless the TIS 1.3 for TPM 2.0 is broken, it should report a bit
_pattern_ (not plain 0x00 or 0xff) that you could apply the suggested
mask to and check then.
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
Ashley Lai <ashley@ashleylai.com>,
Marcel Selhorst <tpmdd@selhorst.net>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
josh@joshtriplett.org, christophe.ricard@gmail.com,
jason.gunthorpe@obsidianresearch.com, linux-api@vger.kernel.org,
trousers-tech@lists.sourceforge.net,
Will Arthur <will.c.arthur@intel.com>
Subject: Re: [PATCH v10 8/8] tpm: TPM 2.0 FIFO Interface
Date: Sun, 14 Dec 2014 09:48:26 -0500 [thread overview]
Message-ID: <548DA33A.4010300@linux.vnet.ibm.com> (raw)
In-Reply-To: <1418413600-5400-9-git-send-email-jarkko.sakkinen@linux.intel.com>
On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
> Detect TPM 2.0 by sending idempotent TPM 2.x command. Ordinals for
> TPM 2.0 are higher than TPM 1.x commands so this should be fail-safe.
> Using STS3 is unreliable because some chips just report 0xff and not
> what the spec says.
TPM TIS 1.2 can report either 0xff or 0x00 for sts3 since that part of
register was not defined for this version but only for a later version.
So, unless the TIS 1.3 for TPM 2.0 is broken, it should report a bit
_pattern_ (not plain 0x00 or 0xff) that you could apply the suggested
mask to and check then.
Stefan
next prev parent reply other threads:[~2014-12-14 14:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 19:46 [PATCH v10 0/8] TPM 2.0 support Jarkko Sakkinen
2014-12-12 19:46 ` Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions Jarkko Sakkinen
[not found] ` <1418413600-5400-2-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-14 14:03 ` Stefan Berger
2014-12-14 14:03 ` Stefan Berger
[not found] ` <548D98B8.3010003-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-12-14 14:57 ` Jarkko Sakkinen
2014-12-14 14:57 ` Jarkko Sakkinen
[not found] ` <1418569030.9230.7.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-14 15:31 ` peterhuewe-Mmb7MZpHnFY
2014-12-14 15:31 ` peterhuewe
[not found] ` <889c95a4-ae60-44db-be8a-fd56a9497c78-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2014-12-14 15:42 ` Jarkko Sakkinen
2014-12-14 15:42 ` Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 3/8] tpm: fix raciness of PPI interface lookup Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 5/8] tpm: device class for tpm Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 6/8] tpm: TPM 2.0 baseline support Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 7/8] tpm: TPM 2.0 CRB Interface Jarkko Sakkinen
2014-12-13 17:53 ` [tpmdd-devel] [PATCH v10 0/8] TPM 2.0 support Scot Doyle
2014-12-14 14:56 ` Jarkko Sakkinen
[not found] ` <1418413600-5400-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-12 19:46 ` [PATCH v10 2/8] tpm: two-phase chip management functions Jarkko Sakkinen
2014-12-12 19:46 ` Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 4/8] tpm: rename chip->dev to chip->pdev Jarkko Sakkinen
2014-12-12 19:46 ` Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 8/8] tpm: TPM 2.0 FIFO Interface Jarkko Sakkinen
2014-12-12 19:46 ` Jarkko Sakkinen
[not found] ` <1418413600-5400-9-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-14 14:48 ` Stefan Berger [this message]
2014-12-14 14:48 ` Stefan Berger
[not found] ` <548DA33A.4010300-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-12-14 15:40 ` Jarkko Sakkinen
2014-12-14 15:40 ` Jarkko Sakkinen
[not found] ` <20141214154003.GA13338-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-14 16:09 ` Stefan Berger
2014-12-14 16:09 ` Stefan Berger
2014-12-14 18:27 ` Scot Doyle
2014-12-14 20:40 ` Stefan Berger
2014-12-14 23:13 ` Jarkko Sakkinen
2014-12-15 20:17 ` [PATCH v10 0/8] TPM 2.0 support Jarkko Sakkinen
2014-12-15 20:17 ` Jarkko Sakkinen
2014-12-16 21:19 ` Aw: " Peter Huewe
2014-12-16 21:31 ` Jarkko Sakkinen
2014-12-16 21:31 ` Jarkko Sakkinen
2014-12-16 21:32 ` [tpmdd-devel] " Peter Huewe
2014-12-16 21:34 ` Jarkko Sakkinen
2014-12-16 21:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548DA33A.4010300@linux.vnet.ibm.com \
--to=stefanb-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peterhuewe-Mmb7MZpHnFY@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org \
--cc=trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=will.c.arthur-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.