All of lore.kernel.org
 help / color / mirror / Atom feed
From: ykk@rock-chips.com (Kuankuan.Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/6] Those patches is used for dw_hdmi audio.
Date: Mon, 15 Dec 2014 20:46:22 +0800	[thread overview]
Message-ID: <548ED81E.2000108@rock-chips.com> (raw)
In-Reply-To: <20141215120013.GH11285@n2100.arm.linux.org.uk>

Hi Russell:

I got an idea that we can split the pcm dma part code out, after that we 
can chose the buffer transmit way (AUD_DMA or I2S).
In that way i will make another i2s driver to transmit those buffer, but 
in the mainline kernel already lanched an rockchip i2s driver
(rockchip_i2s.c), so seams it maybe not an good way.

what's your opinion, russell?

Best Regards.

? 2014?12?15? 20:00, Russell King - ARM Linux ??:
> On Mon, Dec 15, 2014 at 07:52:06PM +0800, Kuankuan.Yang wrote:
>>   Hi Russell:
>>
>>       thks for your replay, actually you also have send me those
>> dw-hdmi-audio.c patches, and I also agree it's an beautiful way to make
>> hdmi-audio works. Beside,
>>   I try to reuse it into our platform, and actually the system have created
>> the DW_HDMI sound card successfully, but i cannot play any sound  with this
>> sound card.
>>       After dump the registers, I found the part of "Audio DMA Registers"
>> cannot write and always read with 0x00.  So I searching the document
>> "Designware Core
>>   HDMI Transmitter Controller Databook", and found that  "Audio DMA
>> Registers" only present when the hardware configuration parameter AUDIO_IF
>> is set to
>>   AHBAUDDMA. Than I communicate with our IC colleagues, they told me that our
>> cpu rk3288 only support two way to  transmit audio data( I2S & SPDIF ), in
>> that
>> way we do not support AHB_DMA, it's very sad, and this it why i give up this
>> way, also it's my bad that i should replay to u first in the before mail.
> Okay, that means there is some work to be done to figure out how to
> support this correctly so that both the iMX and Rockchip code can
> co-exist together in the mainline kernel - that means we _both_ need
> to work together on this problem _before_ this code gets merged, so
> that we have a common approach between the two code bases.
>
> I really don't want to end up in another cocked up situation like
> what happened with the Dove audio, where it became politically
> impossible for the SolidRun platform to be properly supported by
> mainline kernels.
>

WARNING: multiple messages have this Message-ID (diff)
From: "Kuankuan.Yang" <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: "Philipp Zabel" <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org,
	"Fabio Estevam"
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"Shawn Guo" <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Heiko Stuebner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"Daniel Kurtz" <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Sonny Rao" <sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Dylan Reid" <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Xu Jianqun" <jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"Stéphane Marchesin"
	<marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Lars-Peter Clausen"
	<lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
	"Brian Austin"
	<brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>,
	"Bard Liao" <bardliao-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>,
	"Max Filippov" <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Oder Chiou" <oder_chiou-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>,
	"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
	"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Ian Campbell"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
	"Sean Cross" <xobs-nXMMniAx+RbQT0dZR+AlfA@public.gmane.org>,
	"Grant Likely" <grant.likely@linar>
Subject: Re: [RFC PATCH 0/6] Those patches is used for dw_hdmi audio.
Date: Mon, 15 Dec 2014 20:46:22 +0800	[thread overview]
Message-ID: <548ED81E.2000108@rock-chips.com> (raw)
In-Reply-To: <20141215120013.GH11285-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>

Hi Russell:

I got an idea that we can split the pcm dma part code out, after that we 
can chose the buffer transmit way (AUD_DMA or I2S).
In that way i will make another i2s driver to transmit those buffer, but 
in the mainline kernel already lanched an rockchip i2s driver
(rockchip_i2s.c), so seams it maybe not an good way.

what's your opinion, russell?

Best Regards.

在 2014年12月15日 20:00, Russell King - ARM Linux 写道:
> On Mon, Dec 15, 2014 at 07:52:06PM +0800, Kuankuan.Yang wrote:
>>   Hi Russell:
>>
>>       thks for your replay, actually you also have send me those
>> dw-hdmi-audio.c patches, and I also agree it's an beautiful way to make
>> hdmi-audio works. Beside,
>>   I try to reuse it into our platform, and actually the system have created
>> the DW_HDMI sound card successfully, but i cannot play any sound  with this
>> sound card.
>>       After dump the registers, I found the part of "Audio DMA Registers"
>> cannot write and always read with 0x00.  So I searching the document
>> "Designware Core
>>   HDMI Transmitter Controller Databook", and found that  "Audio DMA
>> Registers" only present when the hardware configuration parameter AUDIO_IF
>> is set to
>>   AHBAUDDMA. Than I communicate with our IC colleagues, they told me that our
>> cpu rk3288 only support two way to  transmit audio data( I2S & SPDIF ), in
>> that
>> way we do not support AHB_DMA, it's very sad, and this it why i give up this
>> way, also it's my bad that i should replay to u first in the before mail.
> Okay, that means there is some work to be done to figure out how to
> support this correctly so that both the iMX and Rockchip code can
> co-exist together in the mainline kernel - that means we _both_ need
> to work together on this problem _before_ this code gets merged, so
> that we have a common approach between the two code bases.
>
> I really don't want to end up in another cocked up situation like
> what happened with the Dove audio, where it became politically
> impossible for the SolidRun platform to be properly supported by
> mainline kernels.
>


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Kuankuan.Yang" <ykk@rock-chips.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Philipp Zabel" <p.zabel@pengutronix.de>,
	Zubair.Kakakhel@imgtec.com,
	"Fabio Estevam" <fabio.estevam@freescale.com>,
	"Shawn Guo" <shawn.guo@linaro.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Daniel Kurtz" <djkurtz@chromium.org>,
	"Sonny Rao" <sonnyrao@chromium.org>,
	"Dylan Reid" <dgreid@chromium.org>,
	"Xu Jianqun" <jay.xu@rock-chips.com>,
	"Stéphane Marchesin" <marcheu@chromium.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Brian Austin" <brian.austin@cirrus.com>,
	"Bard Liao" <bardliao@realtek.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Oder Chiou" <oder_chiou@realtek.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Rob Herring" <robh+dt@kernel.org>,
	"David Airlie" <airlied@linux.ie>, "Sean Cross" <xobs@kosagi.com>,
	"Grant Likely" <grant.likely@linaro.org>,
	linux-rockchip@lists.infradead.org,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ben Zhang" <benzh@chromium.org>,
	devicetree@vger.kernel.org, "Liam Girdwood" <lgirdwood@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Mark Brown" <broonie@kernel.org>, "Takashi Iwai" <tiwai@suse.de>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Jyri Sarha" <jsarha@ti.com>
Subject: Re: [RFC PATCH 0/6] Those patches is used for dw_hdmi audio.
Date: Mon, 15 Dec 2014 20:46:22 +0800	[thread overview]
Message-ID: <548ED81E.2000108@rock-chips.com> (raw)
In-Reply-To: <20141215120013.GH11285@n2100.arm.linux.org.uk>

Hi Russell:

I got an idea that we can split the pcm dma part code out, after that we 
can chose the buffer transmit way (AUD_DMA or I2S).
In that way i will make another i2s driver to transmit those buffer, but 
in the mainline kernel already lanched an rockchip i2s driver
(rockchip_i2s.c), so seams it maybe not an good way.

what's your opinion, russell?

Best Regards.

在 2014年12月15日 20:00, Russell King - ARM Linux 写道:
> On Mon, Dec 15, 2014 at 07:52:06PM +0800, Kuankuan.Yang wrote:
>>   Hi Russell:
>>
>>       thks for your replay, actually you also have send me those
>> dw-hdmi-audio.c patches, and I also agree it's an beautiful way to make
>> hdmi-audio works. Beside,
>>   I try to reuse it into our platform, and actually the system have created
>> the DW_HDMI sound card successfully, but i cannot play any sound  with this
>> sound card.
>>       After dump the registers, I found the part of "Audio DMA Registers"
>> cannot write and always read with 0x00.  So I searching the document
>> "Designware Core
>>   HDMI Transmitter Controller Databook", and found that  "Audio DMA
>> Registers" only present when the hardware configuration parameter AUDIO_IF
>> is set to
>>   AHBAUDDMA. Than I communicate with our IC colleagues, they told me that our
>> cpu rk3288 only support two way to  transmit audio data( I2S & SPDIF ), in
>> that
>> way we do not support AHB_DMA, it's very sad, and this it why i give up this
>> way, also it's my bad that i should replay to u first in the before mail.
> Okay, that means there is some work to be done to figure out how to
> support this correctly so that both the iMX and Rockchip code can
> co-exist together in the mainline kernel - that means we _both_ need
> to work together on this problem _before_ this code gets merged, so
> that we have a common approach between the two code bases.
>
> I really don't want to end up in another cocked up situation like
> what happened with the Dove audio, where it became politically
> impossible for the SolidRun platform to be properly supported by
> mainline kernels.
>



  reply	other threads:[~2014-12-15 12:46 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15  2:11 [RFC PATCH 0/6] Those patches is used for dw_hdmi audio Yakir Yang
2014-12-15  2:11 ` Yakir Yang
2014-12-15  2:11 ` Yakir Yang
2014-12-15  2:11 ` [PATCH 1/6] drm: bridge/dw_hdmi: add hdmi audio config interfaces Yakir Yang
2014-12-15  2:11 ` [PATCH 2/6] drm: bridge/bridge: add support for rk3288 hdmi-audio Yakir Yang
     [not found] ` <1418609494-15820-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-15  2:11   ` [PATCH 3/6] ASoC: dw-hdmi-audio: add codec driver for dw hdmi audio Yakir Yang
2014-12-15  2:11     ` Yakir Yang
2014-12-15 10:38   ` [RFC PATCH 0/6] Those patches is used for dw_hdmi audio Russell King - ARM Linux
2014-12-15 10:38     ` Russell King - ARM Linux
2014-12-15 10:38     ` Russell King - ARM Linux
2014-12-15 11:45     ` Kuankuan.Yang
2014-12-15 11:52       ` Kuankuan.Yang
2014-12-15 11:52         ` Kuankuan.Yang
2014-12-15 11:52         ` Kuankuan.Yang
2014-12-15 12:00         ` Russell King - ARM Linux
2014-12-15 12:00           ` Russell King - ARM Linux
2014-12-15 12:00           ` Russell King - ARM Linux
2014-12-15 12:46           ` Kuankuan.Yang [this message]
2014-12-15 12:46             ` Kuankuan.Yang
2014-12-15 12:46             ` Kuankuan.Yang
2014-12-15 15:48           ` Jean-Francois Moine
2014-12-15 15:48             ` Jean-Francois Moine
2014-12-15 15:48             ` Jean-Francois Moine
2014-12-15  2:11 ` [PATCH 4/6] ASoC: rockchip-hdmi-audio: add sound driver for hdmi audio Yakir Yang
2014-12-15  2:11   ` Yakir Yang
2014-12-15  2:11   ` Yakir Yang
2014-12-15  2:55 ` [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio Yakir Yang
2014-12-15  2:55   ` Yakir Yang
2014-12-15  2:55   ` Yakir Yang
     [not found]   ` <1418612114-19692-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-15  9:02     ` Lars-Peter Clausen
2014-12-15  9:02       ` Lars-Peter Clausen
2014-12-15  9:02       ` Lars-Peter Clausen
2014-12-15  9:28       ` ykk
     [not found]       ` <548EA3B9.5080407-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-12-15  9:46         ` Kuankuan.Yang
2014-12-15  9:46           ` Kuankuan.Yang
2014-12-15  9:46           ` Kuankuan.Yang
2014-12-15 10:40     ` Russell King - ARM Linux
2014-12-15 10:40       ` Russell King - ARM Linux
2014-12-15 10:40       ` Russell King - ARM Linux
2014-12-15 12:02       ` Mark Brown
2014-12-15 12:02         ` Mark Brown
2014-12-15 12:02         ` Mark Brown
     [not found]         ` <20141215120205.GZ11764-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-12-15 13:10           ` Kuankuan.Yang
2014-12-15 13:10             ` Kuankuan.Yang
2014-12-15 13:10             ` Kuankuan.Yang
     [not found]             ` <548EDDC2.9050104-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-15 16:18               ` Mark Brown
2014-12-15 16:18                 ` Mark Brown
2014-12-15 16:18                 ` Mark Brown
     [not found]                 ` <20141215161827.GE11764-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-12-16  2:14                   ` Kuankuan.Yang
2014-12-16  2:14                     ` Kuankuan.Yang
2014-12-16  2:14                     ` Kuankuan.Yang
2014-12-16  2:38                   ` Kuankuan.Yang
2014-12-16  2:38                     ` Kuankuan.Yang
2014-12-16  2:38                     ` Kuankuan.Yang
2014-12-16  6:17                   ` Kuankuan.Yang
2014-12-16  6:17                     ` Kuankuan.Yang
2014-12-16  6:17                     ` Kuankuan.Yang
     [not found]                     ` <548FCE8F.7090106-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-16  9:34                       ` Russell King - ARM Linux
2014-12-16  9:34                         ` Russell King - ARM Linux
2014-12-16  9:34                         ` Russell King - ARM Linux
     [not found]                         ` <20141216093443.GN11285-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-12-16  9:48                           ` Kuankuan.Yang
2014-12-16  9:48                             ` Kuankuan.Yang
2014-12-16  9:48                             ` Kuankuan.Yang
2014-12-15  2:56 ` [PATCH 6/6] ARM: dts: rockchip: add hdmi audio nodes Yakir Yang
2014-12-15  2:56   ` Yakir Yang
2014-12-15  2:56   ` Yakir Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548ED81E.2000108@rock-chips.com \
    --to=ykk@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.