* [PATCH] drm/i915: Warn about missing context state workarounds only once
@ 2014-11-26 14:21 Michel Thierry
2014-11-26 23:07 ` [PATCH] drm/i915: Warn about missing context state shuang.he
2014-12-15 15:40 ` [PATCH] drm/i915: Warn about missing context state workarounds only once Tvrtko Ursulin
0 siblings, 2 replies; 4+ messages in thread
From: Michel Thierry @ 2014-11-26 14:21 UTC (permalink / raw)
To: intel-gfx
Otherwise, new platforms without workarounds will hit this warning for
every new context created.
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 2 +-
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 4d41f5a..4111cdd 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1164,7 +1164,7 @@ static int intel_logical_ring_workarounds_emit(struct intel_engine_cs *ring,
struct drm_i915_private *dev_priv = dev->dev_private;
struct i915_workarounds *w = &dev_priv->workarounds;
- if (WARN_ON(w->count == 0))
+ if (WARN_ON_ONCE(w->count == 0))
return 0;
ring->gpu_caches_dirty = true;
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 1d01b51..104edf6 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -669,7 +669,7 @@ static int intel_ring_workarounds_emit(struct intel_engine_cs *ring,
struct drm_i915_private *dev_priv = dev->dev_private;
struct i915_workarounds *w = &dev_priv->workarounds;
- if (WARN_ON(w->count == 0))
+ if (WARN_ON_ONCE(w->count == 0))
return 0;
ring->gpu_caches_dirty = true;
--
2.1.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Warn about missing context state
2014-11-26 14:21 [PATCH] drm/i915: Warn about missing context state workarounds only once Michel Thierry
@ 2014-11-26 23:07 ` shuang.he
2014-12-15 15:40 ` [PATCH] drm/i915: Warn about missing context state workarounds only once Tvrtko Ursulin
1 sibling, 0 replies; 4+ messages in thread
From: shuang.he @ 2014-11-26 23:07 UTC (permalink / raw)
To: shuang.he, intel-gfx, michel.thierry
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 366/366 366/366
ILK -9 371/371 362/371
SNB 450/450 450/450
IVB -1 498/498 497/498
BYT 289/289 289/289
HSW 564/564 564/564
BDW 417/417 417/417
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
ILK igt_gem_reset_stats_close-pending-fork-render TIMEOUT(25, M37M26)PASS(1, M26) TIMEOUT(1, M26)
ILK igt_kms_flip_flip-vs-dpms-off-vs-modeset DMESG_WARN(2, M26)PASS(4, M37M26) DMESG_WARN(1, M26)
ILK igt_kms_flip_rcs-flip-vs-panning-interruptible DMESG_WARN(2, M26)PASS(3, M37M26) DMESG_WARN(1, M26)
ILK igt_kms_flip_rcs-wf_vblank-vs-modeset DMESG_WARN(2, M26)PASS(5, M37M26) DMESG_WARN(1, M26)
*ILK igt_kms_flip_flip-vs-dpms-interruptible PASS(5, M37M26) DMESG_WARN(1, M26)
ILK igt_kms_flip_flip-vs-panning DMESG_WARN(1, M26)PASS(2, M37M26) DMESG_WARN(1, M26)
ILK igt_kms_flip_plain-flip DMESG_WARN(2, M26)PASS(5, M37M26) DMESG_WARN(1, M26)
ILK igt_kms_flip_plain-flip-ts-check-interruptible DMESG_WARN(1, M26)PASS(2, M37M26) DMESG_WARN(1, M26)
ILK igt_kms_flip_vblank-vs-hang NSPT(1, M26)TIMEOUT(23, M37M26)PASS(1, M26) TIMEOUT(1, M26)
*IVB igt_kms_cursor_crc_cursor-64x64-offscreen PASS(3, M21) DMESG_WARN(1, M21)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Warn about missing context state workarounds only once
2014-11-26 14:21 [PATCH] drm/i915: Warn about missing context state workarounds only once Michel Thierry
2014-11-26 23:07 ` [PATCH] drm/i915: Warn about missing context state shuang.he
@ 2014-12-15 15:40 ` Tvrtko Ursulin
2014-12-15 15:54 ` Daniel Vetter
1 sibling, 1 reply; 4+ messages in thread
From: Tvrtko Ursulin @ 2014-12-15 15:40 UTC (permalink / raw)
To: Michel Thierry, intel-gfx
Backtraces make me jump and this one is very noisy, please merge. :)
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
On 11/26/2014 02:21 PM, Michel Thierry wrote:
> Otherwise, new platforms without workarounds will hit this warning for
> every new context created.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 2 +-
> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 4d41f5a..4111cdd 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1164,7 +1164,7 @@ static int intel_logical_ring_workarounds_emit(struct intel_engine_cs *ring,
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct i915_workarounds *w = &dev_priv->workarounds;
>
> - if (WARN_ON(w->count == 0))
> + if (WARN_ON_ONCE(w->count == 0))
> return 0;
>
> ring->gpu_caches_dirty = true;
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 1d01b51..104edf6 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -669,7 +669,7 @@ static int intel_ring_workarounds_emit(struct intel_engine_cs *ring,
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct i915_workarounds *w = &dev_priv->workarounds;
>
> - if (WARN_ON(w->count == 0))
> + if (WARN_ON_ONCE(w->count == 0))
> return 0;
>
> ring->gpu_caches_dirty = true;
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Warn about missing context state workarounds only once
2014-12-15 15:40 ` [PATCH] drm/i915: Warn about missing context state workarounds only once Tvrtko Ursulin
@ 2014-12-15 15:54 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2014-12-15 15:54 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
On Mon, Dec 15, 2014 at 03:40:11PM +0000, Tvrtko Ursulin wrote:
>
> Backtraces make me jump and this one is very noisy, please merge. :)
It's kinda the point ;-)
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> On 11/26/2014 02:21 PM, Michel Thierry wrote:
> >Otherwise, new platforms without workarounds will hit this warning for
> >every new context created.
> >
> >Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> >---
> > drivers/gpu/drm/i915/intel_lrc.c | 2 +-
> > drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> >index 4d41f5a..4111cdd 100644
> >--- a/drivers/gpu/drm/i915/intel_lrc.c
> >+++ b/drivers/gpu/drm/i915/intel_lrc.c
> >@@ -1164,7 +1164,7 @@ static int intel_logical_ring_workarounds_emit(struct intel_engine_cs *ring,
> > struct drm_i915_private *dev_priv = dev->dev_private;
> > struct i915_workarounds *w = &dev_priv->workarounds;
> >
> >- if (WARN_ON(w->count == 0))
> >+ if (WARN_ON_ONCE(w->count == 0))
> > return 0;
> >
> > ring->gpu_caches_dirty = true;
> >diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >index 1d01b51..104edf6 100644
> >--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> >+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >@@ -669,7 +669,7 @@ static int intel_ring_workarounds_emit(struct intel_engine_cs *ring,
> > struct drm_i915_private *dev_priv = dev->dev_private;
> > struct i915_workarounds *w = &dev_priv->workarounds;
> >
> >- if (WARN_ON(w->count == 0))
> >+ if (WARN_ON_ONCE(w->count == 0))
> > return 0;
> >
> > ring->gpu_caches_dirty = true;
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-15 15:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-26 14:21 [PATCH] drm/i915: Warn about missing context state workarounds only once Michel Thierry
2014-11-26 23:07 ` [PATCH] drm/i915: Warn about missing context state shuang.he
2014-12-15 15:40 ` [PATCH] drm/i915: Warn about missing context state workarounds only once Tvrtko Ursulin
2014-12-15 15:54 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.