From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko
<ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH/RFC] spi: sh-msiof: Add runtime PM lock in initializing
Date: Mon, 15 Dec 2014 18:19:59 +0000 [thread overview]
Message-ID: <548F264F.5000901@cogentembedded.com> (raw)
In-Reply-To: <1418652071-6396-1-git-send-email-ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello.
On 12/15/2014 05:01 PM, Yoshihiro Kaneko wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> SH-MSIOF driver is enabled autosuspend API of spi framework.
> But autosuspend framework doesn't work during initializing.
> So runtime PM lock is added in SH-MSIOF driver initializing.
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> This patch is based on the for-next branch of Mark Brown's spi tree.
> drivers/spi/spi-sh-msiof.c | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> index 3f36540..1405293 100644
> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
[...]
> @@ -498,6 +500,9 @@ static int sh_msiof_spi_setup(struct spi_device *spi)
> if (spi->cs_gpio >= 0)
> gpio_set_value(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH));
>
> +
> + pm_runtime_put_sync(&p->pdev->dev);
> +
Do you really need the sync version here?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Yoshihiro Kaneko
<ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH/RFC] spi: sh-msiof: Add runtime PM lock in initializing
Date: Mon, 15 Dec 2014 21:19:59 +0300 [thread overview]
Message-ID: <548F264F.5000901@cogentembedded.com> (raw)
In-Reply-To: <1418652071-6396-1-git-send-email-ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello.
On 12/15/2014 05:01 PM, Yoshihiro Kaneko wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> SH-MSIOF driver is enabled autosuspend API of spi framework.
> But autosuspend framework doesn't work during initializing.
> So runtime PM lock is added in SH-MSIOF driver initializing.
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> This patch is based on the for-next branch of Mark Brown's spi tree.
> drivers/spi/spi-sh-msiof.c | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> index 3f36540..1405293 100644
> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
[...]
> @@ -498,6 +500,9 @@ static int sh_msiof_spi_setup(struct spi_device *spi)
> if (spi->cs_gpio >= 0)
> gpio_set_value(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH));
>
> +
> + pm_runtime_put_sync(&p->pdev->dev);
> +
Do you really need the sync version here?
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-15 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 14:01 [PATCH/RFC] spi: sh-msiof: Add runtime PM lock in initializing Yoshihiro Kaneko
2014-12-15 14:01 ` Yoshihiro Kaneko
[not found] ` <1418652071-6396-1-git-send-email-ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-15 17:39 ` Mark Brown
2014-12-15 17:39 ` Mark Brown
2014-12-15 18:19 ` Sergei Shtylyov [this message]
2014-12-15 18:19 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F264F.5000901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ykaneko0929-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.