All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
Date: Tue, 16 Dec 2014 09:28:40 +0100	[thread overview]
Message-ID: <548FED38.40802@topic.nl> (raw)
In-Reply-To: <2021B186DC632746BD5A3CE32F12BD28E9FE2BDA@EU-MBX-03.mgc.mentorg.com>

On 12/16/2014 08:26 AM, Belal, Awais wrote:
> ping!
>
> BR,
> Awais
>
> 

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/

________________________________________
> From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Belal, Awais
> Sent: Monday, December 08, 2014 3:42 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
>
> The mplayer "make install" phase leaves an empty
> /usr/lib directory seemingly regardless of the setting
> of libdir.  Remove it to avoid a packaging warning.
>
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
>   meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 6b3d120..a68a2ba 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -141,4 +141,5 @@ do_install() {
>       install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
>       install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
>       install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
> +    [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib

This will cause the script to fail when someone fixes the install and /usr/lib 
was not created, because "test -e ${D}/usr/lib" would return failure.


>   }
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



  reply	other threads:[~2014-12-16  8:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 10:42 [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Awais Belal
2014-12-08 10:42 ` [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories Awais Belal
2014-12-16  7:26   ` Belal, Awais
2014-12-16  8:28     ` Mike Looijmans [this message]
2014-12-17 13:55       ` Belal, Awais
2014-12-18  5:46         ` Belal, Awais
2014-12-16  7:26 ` [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Belal, Awais

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548FED38.40802@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.