* [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S)
@ 2014-12-08 10:42 Awais Belal
2014-12-08 10:42 ` [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories Awais Belal
2014-12-16 7:26 ` [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Belal, Awais
0 siblings, 2 replies; 7+ messages in thread
From: Awais Belal @ 2014-12-08 10:42 UTC (permalink / raw)
To: openembedded-devel
The mplayer2 package does not support out of tree builds
and the do_configure step also tries to find the configure
script in the same build directory while the script lies in
the src directory.
This patch updates the builddir to point to the srcdir in
order to cope with the above issues.
Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 65fab1f..6b3d120 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -36,7 +36,7 @@ CONFFILES_${PN} += "/usr/etc/mplayer/input.conf \
/usr/etc/mplayer/codecs.conf \
"
-inherit autotools pkgconfig
+inherit autotools-brokensep pkgconfig
EXTRA_OECONF = " \
--prefix=/usr \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
2014-12-08 10:42 [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Awais Belal
@ 2014-12-08 10:42 ` Awais Belal
2014-12-16 7:26 ` Belal, Awais
2014-12-16 7:26 ` [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Belal, Awais
1 sibling, 1 reply; 7+ messages in thread
From: Awais Belal @ 2014-12-08 10:42 UTC (permalink / raw)
To: openembedded-devel
The mplayer "make install" phase leaves an empty
/usr/lib directory seemingly regardless of the setting
of libdir. Remove it to avoid a packaging warning.
Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 6b3d120..a68a2ba 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -141,4 +141,5 @@ do_install() {
install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
+ [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
2014-12-08 10:42 ` [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories Awais Belal
@ 2014-12-16 7:26 ` Belal, Awais
2014-12-16 8:28 ` Mike Looijmans
0 siblings, 1 reply; 7+ messages in thread
From: Belal, Awais @ 2014-12-16 7:26 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org
ping!
BR,
Awais
________________________________________
From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Belal, Awais
Sent: Monday, December 08, 2014 3:42 PM
To: openembedded-devel@lists.openembedded.org
Subject: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
The mplayer "make install" phase leaves an empty
/usr/lib directory seemingly regardless of the setting
of libdir. Remove it to avoid a packaging warning.
Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 6b3d120..a68a2ba 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -141,4 +141,5 @@ do_install() {
install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
+ [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
}
--
1.7.9.5
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S)
2014-12-08 10:42 [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Awais Belal
2014-12-08 10:42 ` [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories Awais Belal
@ 2014-12-16 7:26 ` Belal, Awais
1 sibling, 0 replies; 7+ messages in thread
From: Belal, Awais @ 2014-12-16 7:26 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org
ping!
BR,
Awais
________________________________________
From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Belal, Awais
Sent: Monday, December 08, 2014 3:42 PM
To: openembedded-devel@lists.openembedded.org
Subject: [oe] [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S)
The mplayer2 package does not support out of tree builds
and the do_configure step also tries to find the configure
script in the same build directory while the script lies in
the src directory.
This patch updates the builddir to point to the srcdir in
order to cope with the above issues.
Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 65fab1f..6b3d120 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -36,7 +36,7 @@ CONFFILES_${PN} += "/usr/etc/mplayer/input.conf \
/usr/etc/mplayer/codecs.conf \
"
-inherit autotools pkgconfig
+inherit autotools-brokensep pkgconfig
EXTRA_OECONF = " \
--prefix=/usr \
--
1.7.9.5
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
2014-12-16 7:26 ` Belal, Awais
@ 2014-12-16 8:28 ` Mike Looijmans
2014-12-17 13:55 ` Belal, Awais
0 siblings, 1 reply; 7+ messages in thread
From: Mike Looijmans @ 2014-12-16 8:28 UTC (permalink / raw)
To: openembedded-devel
On 12/16/2014 08:26 AM, Belal, Awais wrote:
> ping!
>
> BR,
> Awais
>
>
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax: (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl
Please consider the environment before printing this e-mail
Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/
________________________________________
> From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Belal, Awais
> Sent: Monday, December 08, 2014 3:42 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
>
> The mplayer "make install" phase leaves an empty
> /usr/lib directory seemingly regardless of the setting
> of libdir. Remove it to avoid a packaging warning.
>
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 6b3d120..a68a2ba 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -141,4 +141,5 @@ do_install() {
> install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
> + [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
This will cause the script to fail when someone fixes the install and /usr/lib
was not created, because "test -e ${D}/usr/lib" would return failure.
> }
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
2014-12-16 8:28 ` Mike Looijmans
@ 2014-12-17 13:55 ` Belal, Awais
2014-12-18 5:46 ` Belal, Awais
0 siblings, 1 reply; 7+ messages in thread
From: Belal, Awais @ 2014-12-17 13:55 UTC (permalink / raw)
To: mike.looijmans@topic.nl; +Cc: openembedded-devel@lists.openembedded.org
Hi Mike,
Thanks for the feedback. Do you think
if [ -d ${D}/usr/lib ]; then
rmdir ${D}/usr/lib
fi
would be a better solution here?
BR,
Awais
________________________________________
From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Mike Looijmans [mike.looijmans@topic.nl]
Sent: Tuesday, December 16, 2014 1:28 PM
To: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
On 12/16/2014 08:26 AM, Belal, Awais wrote:
> ping!
>
> BR,
> Awais
>
>
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax: (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl
Please consider the environment before printing this e-mail
Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/
________________________________________
> From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Belal, Awais
> Sent: Monday, December 08, 2014 3:42 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
>
> The mplayer "make install" phase leaves an empty
> /usr/lib directory seemingly regardless of the setting
> of libdir. Remove it to avoid a packaging warning.
>
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 6b3d120..a68a2ba 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -141,4 +141,5 @@ do_install() {
> install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
> + [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
This will cause the script to fail when someone fixes the install and /usr/lib
was not created, because "test -e ${D}/usr/lib" would return failure.
> }
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
2014-12-17 13:55 ` Belal, Awais
@ 2014-12-18 5:46 ` Belal, Awais
0 siblings, 0 replies; 7+ messages in thread
From: Belal, Awais @ 2014-12-18 5:46 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org,
mike.looijmans@topic.nl
On second though I believe we should keep it as-is. The reason being that once the install is fixed this should fail ideally so we know that this needs to be stripped out of the recipe at the same time.
BR,
Awais
________________________________________
From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Belal, Awais
Sent: Wednesday, December 17, 2014 6:55 PM
To: mike.looijmans@topic.nl
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
Hi Mike,
Thanks for the feedback. Do you think
if [ -d ${D}/usr/lib ]; then
rmdir ${D}/usr/lib
fi
would be a better solution here?
BR,
Awais
________________________________________
From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Mike Looijmans [mike.looijmans@topic.nl]
Sent: Tuesday, December 16, 2014 1:28 PM
To: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
On 12/16/2014 08:26 AM, Belal, Awais wrote:
> ping!
>
> BR,
> Awais
>
>
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax: (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl
Please consider the environment before printing this e-mail
Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/
________________________________________
> From: openembedded-devel-bounces@lists.openembedded.org [openembedded-devel-bounces@lists.openembedded.org] on behalf of Belal, Awais
> Sent: Monday, December 08, 2014 3:42 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories
>
> The mplayer "make install" phase leaves an empty
> /usr/lib directory seemingly regardless of the setting
> of libdir. Remove it to avoid a packaging warning.
>
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 6b3d120..a68a2ba 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -141,4 +141,5 @@ do_install() {
> install ${S}/etc/input.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/example.conf ${D}/usr/etc/mplayer/
> install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/
> + [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib
This will cause the script to fail when someone fixes the install and /usr/lib
was not created, because "test -e ${D}/usr/lib" would return failure.
> }
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-12-18 5:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-08 10:42 [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Awais Belal
2014-12-08 10:42 ` [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories Awais Belal
2014-12-16 7:26 ` Belal, Awais
2014-12-16 8:28 ` Mike Looijmans
2014-12-17 13:55 ` Belal, Awais
2014-12-18 5:46 ` Belal, Awais
2014-12-16 7:26 ` [meta-oe][PATCH v2 1/2] mplayer2: use autotools-brokensep (B = S) Belal, Awais
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.