* FIXED_PHY is broken... @ 2014-12-16 16:25 David Miller 2014-12-16 16:36 ` [info] Kconfig SELECT statement rules - was: " Oliver Hartkopp 2014-12-16 19:30 ` David Miller 0 siblings, 2 replies; 5+ messages in thread From: David Miller @ 2014-12-16 16:25 UTC (permalink / raw) To: netdev; +Cc: f.fainelli I get this now when I run oldconfig: warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) For the thousandth time, you cannot select Kconfig options which have dependencies of any kind, because select does not recursively cause dependencies to be enabled up to the root of the Kconfig tree. If you select on something which has a "depends on", stop right there because you can't do it. It only works for pure leaf Kconfig nodes with no deps. All you needed to do in order to test this was do an allmodconfig build. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [info] Kconfig SELECT statement rules - was: FIXED_PHY is broken... 2014-12-16 16:25 FIXED_PHY is broken David Miller @ 2014-12-16 16:36 ` Oliver Hartkopp 2014-12-16 19:30 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: Oliver Hartkopp @ 2014-12-16 16:36 UTC (permalink / raw) To: linux-can@vger.kernel.org Just a hint from Dave when the SELECT statement is not appropriate when creating Kconfig files ... ;-) Regards, Oliver -------- Forwarded Message -------- Subject: FIXED_PHY is broken... Date: Tue, 16 Dec 2014 11:25:34 -0500 (EST) From: David Miller <davem@davemloft.net> To: netdev@vger.kernel.org CC: f.fainelli@gmail.com I get this now when I run oldconfig: warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) For the thousandth time, you cannot select Kconfig options which have dependencies of any kind, because select does not recursively cause dependencies to be enabled up to the root of the Kconfig tree. If you select on something which has a "depends on", stop right there because you can't do it. It only works for pure leaf Kconfig nodes with no deps. All you needed to do in order to test this was do an allmodconfig build. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: FIXED_PHY is broken... 2014-12-16 16:25 FIXED_PHY is broken David Miller 2014-12-16 16:36 ` [info] Kconfig SELECT statement rules - was: " Oliver Hartkopp @ 2014-12-16 19:30 ` David Miller 2014-12-16 20:15 ` David Miller 1 sibling, 1 reply; 5+ messages in thread From: David Miller @ 2014-12-16 19:30 UTC (permalink / raw) To: netdev; +Cc: f.fainelli From: David Miller <davem@davemloft.net> Date: Tue, 16 Dec 2014 11:25:34 -0500 (EST) > I get this now when I run oldconfig: > > warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) Here is how I'm going to fix this. FIXED_PHY needs to be allowed to be modular, and built even if PHYLIB is modular too. ==================== [PATCH] net: Allow FIXED_PHY to be modular. Otherwise we get things like: warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/phy/Kconfig | 4 ++-- include/linux/phy_fixed.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index b4b0f80..a3c251b 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -119,8 +119,8 @@ config MICREL_PHY Supports the KSZ9021, VSC8201, KS8001 PHYs. config FIXED_PHY - bool "Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs" - depends on PHYLIB=y + tristate "Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs" + depends on PHYLIB ---help--- Adds the platform "fixed" MDIO Bus to cover the boards that use PHYs that are not connected to the real MDIO bus. diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h index f2ca1b4..7e75bfe 100644 --- a/include/linux/phy_fixed.h +++ b/include/linux/phy_fixed.h @@ -11,7 +11,7 @@ struct fixed_phy_status { struct device_node; -#ifdef CONFIG_FIXED_PHY +#if IS_ENABLED(CONFIG_FIXED_PHY) extern int fixed_phy_add(unsigned int irq, int phy_id, struct fixed_phy_status *status); extern struct phy_device *fixed_phy_register(unsigned int irq, -- 1.7.11.7 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: FIXED_PHY is broken... 2014-12-16 19:30 ` David Miller @ 2014-12-16 20:15 ` David Miller 2014-12-16 20:23 ` Florian Fainelli 0 siblings, 1 reply; 5+ messages in thread From: David Miller @ 2014-12-16 20:15 UTC (permalink / raw) To: netdev; +Cc: f.fainelli From: David Miller <davem@davemloft.net> Date: Tue, 16 Dec 2014 14:30:27 -0500 (EST) > From: David Miller <davem@davemloft.net> > Date: Tue, 16 Dec 2014 11:25:34 -0500 (EST) > >> I get this now when I run oldconfig: >> >> warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) > > Here is how I'm going to fix this. > > FIXED_PHY needs to be allowed to be modular, and built even if PHYLIB is > modular too. > > ==================== > [PATCH] net: Allow FIXED_PHY to be modular. Ok, it takes a little more work, the problem is that there is already a module named fixed.ko in the regulator layer, so we have to rename this to something else. ==================== [PATCH] net: Allow FIXED_PHY to be modular. Otherwise we get things like: warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) In order to make this work we have to rename fixed.c to fixed_phy.c because the regulator drivers already have a module named "fixed.o". Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/phy/Kconfig | 4 ++-- drivers/net/phy/Makefile | 2 +- drivers/net/phy/{fixed.c => fixed_phy.c} | 0 include/linux/phy_fixed.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) rename drivers/net/phy/{fixed.c => fixed_phy.c} (100%) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index b4b0f80..a3c251b 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -119,8 +119,8 @@ config MICREL_PHY Supports the KSZ9021, VSC8201, KS8001 PHYs. config FIXED_PHY - bool "Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs" - depends on PHYLIB=y + tristate "Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs" + depends on PHYLIB ---help--- Adds the platform "fixed" MDIO Bus to cover the boards that use PHYs that are not connected to the real MDIO bus. diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile index eb3b18b..501ea76 100644 --- a/drivers/net/phy/Makefile +++ b/drivers/net/phy/Makefile @@ -17,7 +17,7 @@ obj-$(CONFIG_BCM87XX_PHY) += bcm87xx.o obj-$(CONFIG_ICPLUS_PHY) += icplus.o obj-$(CONFIG_REALTEK_PHY) += realtek.o obj-$(CONFIG_LSI_ET1011C_PHY) += et1011c.o -obj-$(CONFIG_FIXED_PHY) += fixed.o +obj-$(CONFIG_FIXED_PHY) += fixed_phy.o obj-$(CONFIG_MDIO_BITBANG) += mdio-bitbang.o obj-$(CONFIG_MDIO_GPIO) += mdio-gpio.o obj-$(CONFIG_NATIONAL_PHY) += national.o diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed_phy.c similarity index 100% rename from drivers/net/phy/fixed.c rename to drivers/net/phy/fixed_phy.c diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h index f2ca1b4..7e75bfe 100644 --- a/include/linux/phy_fixed.h +++ b/include/linux/phy_fixed.h @@ -11,7 +11,7 @@ struct fixed_phy_status { struct device_node; -#ifdef CONFIG_FIXED_PHY +#if IS_ENABLED(CONFIG_FIXED_PHY) extern int fixed_phy_add(unsigned int irq, int phy_id, struct fixed_phy_status *status); extern struct phy_device *fixed_phy_register(unsigned int irq, -- 1.7.11.7 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: FIXED_PHY is broken... 2014-12-16 20:15 ` David Miller @ 2014-12-16 20:23 ` Florian Fainelli 0 siblings, 0 replies; 5+ messages in thread From: Florian Fainelli @ 2014-12-16 20:23 UTC (permalink / raw) To: David Miller, netdev On 16/12/14 12:15, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Tue, 16 Dec 2014 14:30:27 -0500 (EST) > >> From: David Miller <davem@davemloft.net> >> Date: Tue, 16 Dec 2014 11:25:34 -0500 (EST) >> >>> I get this now when I run oldconfig: >>> >>> warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) >> >> Here is how I'm going to fix this. >> >> FIXED_PHY needs to be allowed to be modular, and built even if PHYLIB is >> modular too. You beat me to it, thanks David! >> >> ==================== >> [PATCH] net: Allow FIXED_PHY to be modular. > > Ok, it takes a little more work, the problem is that there is already > a module named fixed.ko in the regulator layer, so we have to rename > this to something else. > > ==================== > [PATCH] net: Allow FIXED_PHY to be modular. > > Otherwise we get things like: > > warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which has unmet direct dependencies (NETDEVICES && PHYLIB=y) > > In order to make this work we have to rename fixed.c to fixed_phy.c > because the regulator drivers already have a module named "fixed.o". > > Signed-off-by: David S. Miller <davem@davemloft.net> Acked-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/net/phy/Kconfig | 4 ++-- > drivers/net/phy/Makefile | 2 +- > drivers/net/phy/{fixed.c => fixed_phy.c} | 0 > include/linux/phy_fixed.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > rename drivers/net/phy/{fixed.c => fixed_phy.c} (100%) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index b4b0f80..a3c251b 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -119,8 +119,8 @@ config MICREL_PHY > Supports the KSZ9021, VSC8201, KS8001 PHYs. > > config FIXED_PHY > - bool "Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs" > - depends on PHYLIB=y > + tristate "Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs" > + depends on PHYLIB > ---help--- > Adds the platform "fixed" MDIO Bus to cover the boards that use > PHYs that are not connected to the real MDIO bus. > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile > index eb3b18b..501ea76 100644 > --- a/drivers/net/phy/Makefile > +++ b/drivers/net/phy/Makefile > @@ -17,7 +17,7 @@ obj-$(CONFIG_BCM87XX_PHY) += bcm87xx.o > obj-$(CONFIG_ICPLUS_PHY) += icplus.o > obj-$(CONFIG_REALTEK_PHY) += realtek.o > obj-$(CONFIG_LSI_ET1011C_PHY) += et1011c.o > -obj-$(CONFIG_FIXED_PHY) += fixed.o > +obj-$(CONFIG_FIXED_PHY) += fixed_phy.o > obj-$(CONFIG_MDIO_BITBANG) += mdio-bitbang.o > obj-$(CONFIG_MDIO_GPIO) += mdio-gpio.o > obj-$(CONFIG_NATIONAL_PHY) += national.o > diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed_phy.c > similarity index 100% > rename from drivers/net/phy/fixed.c > rename to drivers/net/phy/fixed_phy.c > diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h > index f2ca1b4..7e75bfe 100644 > --- a/include/linux/phy_fixed.h > +++ b/include/linux/phy_fixed.h > @@ -11,7 +11,7 @@ struct fixed_phy_status { > > struct device_node; > > -#ifdef CONFIG_FIXED_PHY > +#if IS_ENABLED(CONFIG_FIXED_PHY) > extern int fixed_phy_add(unsigned int irq, int phy_id, > struct fixed_phy_status *status); > extern struct phy_device *fixed_phy_register(unsigned int irq, > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-16 20:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-16 16:25 FIXED_PHY is broken David Miller 2014-12-16 16:36 ` [info] Kconfig SELECT statement rules - was: " Oliver Hartkopp 2014-12-16 19:30 ` David Miller 2014-12-16 20:15 ` David Miller 2014-12-16 20:23 ` Florian Fainelli
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.