From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] tools lib traceevent: Add support for IP address formats
Date: Thu, 18 Dec 2014 08:59:53 -0700 [thread overview]
Message-ID: <5492F9F9.7090207@gmail.com> (raw)
In-Reply-To: <20141218155255.GF3150@kernel.org>
On 12/18/14 8:52 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 18, 2014 at 08:10:43AM -0700, David Ahern escreveu:
>> Adds helper for following kernel formats:
>> %pi4 print an IPv4 address with leading zeros
>> %pI4 print an IPv4 address without leading zeros
>> %pi6 print an IPv6 address without colons
>> %pI6 print an IPv6 address with colons
>> %pI6c print an IPv6 address with colons
>> %pISpc print an IP address from a sockaddr
>>
>> Allows these formats to be used in tracepoints.
>>
>> Quite a bit of this is adapted from code in lib/vsprintf.c.
>
> Can't we try as much as possible use that code directly? Something like
By my reading of that file I don't see how it can be reused directly.
David
next prev parent reply other threads:[~2014-12-18 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 15:10 [PATCH] tools lib traceevent: Add support for IP address formats David Ahern
2014-12-18 15:52 ` Arnaldo Carvalho de Melo
2014-12-18 15:59 ` David Ahern [this message]
2014-12-18 16:27 ` Steven Rostedt
2014-12-18 22:16 ` Arnaldo Carvalho de Melo
2014-12-18 22:50 ` David Ahern
2014-12-18 21:45 ` Valdis.Kletnieks
2014-12-18 22:13 ` David Ahern
2014-12-19 1:41 ` David Ahern
2014-12-22 17:01 ` Jiri Olsa
2014-12-22 17:10 ` David Ahern
2014-12-22 17:28 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2014-12-17 20:29 David Ahern
2014-12-18 4:26 ` Namhyung Kim
2014-12-18 4:32 ` David Ahern
2014-12-18 5:04 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5492F9F9.7090207@gmail.com \
--to=dsahern@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.