From: David Ahern <dsahern@gmail.com>
To: Valdis.Kletnieks@vt.edu
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] tools lib traceevent: Add support for IP address formats
Date: Thu, 18 Dec 2014 18:41:58 -0700 [thread overview]
Message-ID: <54938266.9090007@gmail.com> (raw)
In-Reply-To: <549351A7.9040408@gmail.com>
On 12/18/14 3:13 PM, David Ahern wrote:
> Are you seeing something different?
I put a tracepoint in the ipv4/ipv6 add/del address code. The IPv4 one
prints the address using pi4 and pI4 and the IPv6 using pi6, pI6 and pI6c.
Using ifconfig eth1 1.2.3.4/24
I get this for trace_pipe which uses the in-kernel printf code:
root@localhost:/sys/kernel/debug/tracing/events# cat ../trace_pipe
ifconfig-601 [000] .... 710.660611: ipv4_del_addr:
pI4=1.2.3.4 pi4=001.002.003.004
ifconfig-602 [000] .... 720.833559: ipv4_add_addr:
pI4=1.2.3.4 pi4=001.002.003.004
ifconfig-602 [000] .Ns. 720.833966: ipv6_add_addr:
pi6=fe80000000000000000202fffe020211
pI6=fe80:0000:0000:0000:0002:02ff:fe02:0211 pI6c=fe80::2:2ff:fe02:211
ifconfig-602 [000] .... 720.835413: ipv4_del_addr:
pI4=1.2.3.4 pi4=001.002.003.004
ifconfig-602 [000] .N.. 720.835451: ipv4_add_addr:
pI4=1.2.3.4 pi4=001.002.003.004
And this using perf:
root@localhost:~# perf record -a -e ipv4:* -e ipv6:* --no-buffering |
perf --no-pager script
ifconfig 601 [000] 710.912862: ipv4:ipv4_del_addr:
pI4=1.2.3.4 pi4=001.002.003.004
ifconfig 602 [000] 721.090776: ipv4:ipv4_add_addr:
pI4=1.2.3.4 pi4=001.002.003.004
ifconfig 602 [000] 721.091177: ipv6:ipv6_add_addr:
pi6=fe80000000000000000202fffe020211
pI6=fe80:0000:0000:0000:0002:02ff:fe02:0211 pI6c=fe80::2:2ff:fe02:211
ifconfig 602 [000] 721.092626: ipv4:ipv4_del_addr:
pI4=1.2.3.4 pi4=001.002.003.004
ifconfig 602 [000] 721.092648: ipv4:ipv4_add_addr:
pI4=1.2.3.4 pi4=001.002.003.004
(Don't be fooled by the differing timestamps; data collected from both
using the same exact command. timestamp differences are perf vs tracing.)
which suggest with the patch perf output matches tracing.
David
next prev parent reply other threads:[~2014-12-19 1:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 15:10 [PATCH] tools lib traceevent: Add support for IP address formats David Ahern
2014-12-18 15:52 ` Arnaldo Carvalho de Melo
2014-12-18 15:59 ` David Ahern
2014-12-18 16:27 ` Steven Rostedt
2014-12-18 22:16 ` Arnaldo Carvalho de Melo
2014-12-18 22:50 ` David Ahern
2014-12-18 21:45 ` Valdis.Kletnieks
2014-12-18 22:13 ` David Ahern
2014-12-19 1:41 ` David Ahern [this message]
2014-12-22 17:01 ` Jiri Olsa
2014-12-22 17:10 ` David Ahern
2014-12-22 17:28 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2014-12-17 20:29 David Ahern
2014-12-18 4:26 ` Namhyung Kim
2014-12-18 4:32 ` David Ahern
2014-12-18 5:04 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54938266.9090007@gmail.com \
--to=dsahern@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.