All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Grover <agrover@redhat.com>
To: Kyle McMartin <kyle@redhat.com>, linux-kernel@vger.kernel.org
Cc: nab@linux-iscsi.org, jbastian@redhat.com
Subject: Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness
Date: Thu, 18 Dec 2014 10:02:25 -0800	[thread overview]
Message-ID: <549316B1.8010307@redhat.com> (raw)
In-Reply-To: <20141218175714.GF5157@redacted.bos.redhat.com>

On 12/18/2014 09:57 AM, Kyle McMartin wrote:
> scripts/headers_install.sh will transform __packed to
> __attribute__((packed)), so the #ifndef is not necessary.
> (and, in fact, it's problematic, because we'll end up with the header
>   containing:
> #ifndef __attribute__((packed))
> #define __attribu...
> and so forth.)
>
> Cc: stable@vger.kernel.org # 3.18
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> ---
> cc-ing stable@ so this headers fix gets picked up by distros.

Acked-by: Andy Grover <agrover@redhat.com>


  reply	other threads:[~2014-12-18 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 17:57 [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness Kyle McMartin
2014-12-18 18:02 ` Andy Grover [this message]
2014-12-19  1:19 ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549316B1.8010307@redhat.com \
    --to=agrover@redhat.com \
    --cc=jbastian@redhat.com \
    --cc=kyle@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.