* [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness
@ 2014-12-18 17:57 Kyle McMartin
2014-12-18 18:02 ` Andy Grover
2014-12-19 1:19 ` Nicholas A. Bellinger
0 siblings, 2 replies; 3+ messages in thread
From: Kyle McMartin @ 2014-12-18 17:57 UTC (permalink / raw)
To: linux-kernel; +Cc: agrover, nab, jbastian
scripts/headers_install.sh will transform __packed to
__attribute__((packed)), so the #ifndef is not necessary.
(and, in fact, it's problematic, because we'll end up with the header
containing:
#ifndef __attribute__((packed))
#define __attribu...
and so forth.)
Cc: stable@vger.kernel.org # 3.18
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
cc-ing stable@ so this headers fix gets picked up by distros.
--- a/include/uapi/linux/target_core_user.h
+++ b/include/uapi/linux/target_core_user.h
@@ -6,10 +6,6 @@
#include <linux/types.h>
#include <linux/uio.h>
-#ifndef __packed
-#define __packed __attribute__((packed))
-#endif
-
#define TCMU_VERSION "1.0"
/*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness
2014-12-18 17:57 [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness Kyle McMartin
@ 2014-12-18 18:02 ` Andy Grover
2014-12-19 1:19 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Andy Grover @ 2014-12-18 18:02 UTC (permalink / raw)
To: Kyle McMartin, linux-kernel; +Cc: nab, jbastian
On 12/18/2014 09:57 AM, Kyle McMartin wrote:
> scripts/headers_install.sh will transform __packed to
> __attribute__((packed)), so the #ifndef is not necessary.
> (and, in fact, it's problematic, because we'll end up with the header
> containing:
> #ifndef __attribute__((packed))
> #define __attribu...
> and so forth.)
>
> Cc: stable@vger.kernel.org # 3.18
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> ---
> cc-ing stable@ so this headers fix gets picked up by distros.
Acked-by: Andy Grover <agrover@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness
2014-12-18 17:57 [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness Kyle McMartin
2014-12-18 18:02 ` Andy Grover
@ 2014-12-19 1:19 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas A. Bellinger @ 2014-12-19 1:19 UTC (permalink / raw)
To: Kyle McMartin; +Cc: linux-kernel, agrover, jbastian, target-devel
Hi Kyle,
On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote:
> scripts/headers_install.sh will transform __packed to
> __attribute__((packed)), so the #ifndef is not necessary.
> (and, in fact, it's problematic, because we'll end up with the header
> containing:
> #ifndef __attribute__((packed))
> #define __attribu...
> and so forth.)
>
> Cc: stable@vger.kernel.org # 3.18
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> ---
> cc-ing stable@ so this headers fix gets picked up by distros.
>
> --- a/include/uapi/linux/target_core_user.h
> +++ b/include/uapi/linux/target_core_user.h
> @@ -6,10 +6,6 @@
> #include <linux/types.h>
> #include <linux/uio.h>
>
> -#ifndef __packed
> -#define __packed __attribute__((packed))
> -#endif
> -
> #define TCMU_VERSION "1.0"
>
> /*
Applied to target-pending/for-next.
Thanks!
--nab
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-19 1:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-18 17:57 [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness Kyle McMartin
2014-12-18 18:02 ` Andy Grover
2014-12-19 1:19 ` Nicholas A. Bellinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.