From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ijc@hellion.org.uk>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen: arm: correct off-by-one error in consider_modules
Date: Mon, 22 Dec 2014 11:54:01 +0100 [thread overview]
Message-ID: <5497F849.3050806@linaro.org> (raw)
In-Reply-To: <1419160733-31534-1-git-send-email-ijc@hellion.org.uk>
Hi Ian,
On 21/12/2014 12:18, Ian Campbell wrote:
> By iterating up to <= mi->nr_mods we are running off the end of the boot
> modules, but more importantly it causes us to then skip the first FDT reserved
> region, meaning we might clobber it.
Oops. Good catch!
OOI, how did you find it?
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Reviewed-by: Julien Grall <julien.grall@linaro.org>
> ---
> For 4.5: I think this bug fix should go in, it fixes a real issue and is low
> risk.
Agreed.
> I'll also add to my list of things to consider for backport to 4.4.
Ditto.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-12-22 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 11:18 [PATCH] xen: arm: correct off-by-one error in consider_modules Ian Campbell
2014-12-22 10:54 ` Julien Grall [this message]
2014-12-22 11:39 ` Ian Campbell
2015-01-05 16:17 ` Konrad Rzeszutek Wilk
2015-01-06 11:44 ` Ian Campbell
2015-01-20 14:40 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5497F849.3050806@linaro.org \
--to=julien.grall@linaro.org \
--cc=ijc@hellion.org.uk \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.