From: Andrew Jackson <Andrew.Jackson@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>, Takashi Iwai <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rajeev Kumar <rajeevkumar.linux@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/5] ASoC: dwc: Iterate over all channels
Date: Mon, 22 Dec 2014 14:08:44 +0000 [thread overview]
Message-ID: <549825EC.80505@arm.com> (raw)
In-Reply-To: <20141222135301.GQ17800@sirena.org.uk>
On 12/22/14 13:53, Mark Brown wrote:
> On Fri, Dec 19, 2014 at 04:18:06PM +0000, Andrew Jackson wrote:
>
>> The Designware core can be configured with up to four stereo channels.
>> Each stereo channel is individually configured so, when the driver's
>> hw_params call is made, each requested stereo channel has to be
>> programmed.
>
> This is quite unclear to someone who doesn't know the hardware, is this
> a bug fix or a new feature? It looks like it's a fix...
>
It is a fix. In the Designware core, each stereo channel is configured
individually. So, when hw_params is called to configure N channels,
N/2 stereo channels need to be configured in the core. The existing
code doesn't do this and will only configure the highest numbered
channel.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew.Jackson@arm.com (Andrew Jackson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] ASoC: dwc: Iterate over all channels
Date: Mon, 22 Dec 2014 14:08:44 +0000 [thread overview]
Message-ID: <549825EC.80505@arm.com> (raw)
In-Reply-To: <20141222135301.GQ17800@sirena.org.uk>
On 12/22/14 13:53, Mark Brown wrote:
> On Fri, Dec 19, 2014 at 04:18:06PM +0000, Andrew Jackson wrote:
>
>> The Designware core can be configured with up to four stereo channels.
>> Each stereo channel is individually configured so, when the driver's
>> hw_params call is made, each requested stereo channel has to be
>> programmed.
>
> This is quite unclear to someone who doesn't know the hardware, is this
> a bug fix or a new feature? It looks like it's a fix...
>
It is a fix. In the Designware core, each stereo channel is configured
individually. So, when hw_params is called to configure N channels,
N/2 stereo channels need to be configured in the core. The existing
code doesn't do this and will only configure the highest numbered
channel.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jackson <Andrew.Jackson@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rajeev Kumar <rajeevkumar.linux@gmail.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] ASoC: dwc: Iterate over all channels
Date: Mon, 22 Dec 2014 14:08:44 +0000 [thread overview]
Message-ID: <549825EC.80505@arm.com> (raw)
In-Reply-To: <20141222135301.GQ17800@sirena.org.uk>
On 12/22/14 13:53, Mark Brown wrote:
> On Fri, Dec 19, 2014 at 04:18:06PM +0000, Andrew Jackson wrote:
>
>> The Designware core can be configured with up to four stereo channels.
>> Each stereo channel is individually configured so, when the driver's
>> hw_params call is made, each requested stereo channel has to be
>> programmed.
>
> This is quite unclear to someone who doesn't know the hardware, is this
> a bug fix or a new feature? It looks like it's a fix...
>
It is a fix. In the Designware core, each stereo channel is configured
individually. So, when hw_params is called to configure N channels,
N/2 stereo channels need to be configured in the core. The existing
code doesn't do this and will only configure the highest numbered
channel.
Andrew
next prev parent reply other threads:[~2014-12-22 14:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 16:18 [PATCH v3 0/5] ASoC: dwc: Add device tree support to designware I2S Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-19 16:18 ` [PATCH v3 1/5] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-22 13:45 ` Mark Brown
2014-12-22 13:45 ` Mark Brown
2014-12-19 16:18 ` [PATCH v3 2/5] ASoC: dwc: Iterate over all channels Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-22 13:53 ` Mark Brown
2014-12-22 13:53 ` Mark Brown
2014-12-22 14:08 ` Andrew Jackson [this message]
2014-12-22 14:08 ` Andrew Jackson
2014-12-22 14:08 ` Andrew Jackson
2014-12-22 15:06 ` Mark Brown
2014-12-22 15:06 ` Mark Brown
2014-12-19 16:18 ` [PATCH v3 3/5] ASoC: dwc: Reorder code in preparation for DT support Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-22 14:00 ` Mark Brown
2014-12-22 14:00 ` Mark Brown
2014-12-19 16:18 ` [PATCH v3 4/5] ASoC: dwc: Add devicetree support for Designware I2S Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-22 14:10 ` Mark Brown
2014-12-22 14:10 ` Mark Brown
2014-12-22 14:10 ` Mark Brown
2014-12-22 15:58 ` Andrew Jackson
2014-12-22 15:58 ` Andrew Jackson
2014-12-22 15:58 ` Andrew Jackson
2014-12-22 14:28 ` Mark Brown
2014-12-22 14:28 ` Mark Brown
2014-12-19 16:18 ` [PATCH v3 5/5] ASoC: dwc: Add documentation for I2S DT Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-19 16:18 ` Andrew Jackson
2014-12-22 14:26 ` Mark Brown
2014-12-22 14:26 ` Mark Brown
2014-12-22 15:51 ` Andrew Jackson
2014-12-22 15:51 ` Andrew Jackson
2014-12-22 15:51 ` Andrew Jackson
2014-12-22 16:51 ` Mark Brown
2014-12-22 16:51 ` Mark Brown
2014-12-22 16:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549825EC.80505@arm.com \
--to=andrew.jackson@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajeevkumar.linux@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.