* Testing preemptibility test in xen_setup_cpu_clockevents()
@ 2014-12-22 15:53 Boris Ostrovsky
2014-12-22 16:09 ` [Xen-devel] " David Vrabel
2014-12-22 16:09 ` David Vrabel
0 siblings, 2 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2014-12-22 15:53 UTC (permalink / raw)
To: xen-devel
Cc: David Vrabel, Konrad Rzeszutek Wilk, Linux Kernel Mailing List,
Thomas Gleixner
With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in
native_smp_prepare_cpus()) HVM guests no longer boot since we are
hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().
I don't think we need this test (PV or HVM), do we?
-boris
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] Testing preemptibility test in xen_setup_cpu_clockevents()
2014-12-22 15:53 Testing preemptibility test in xen_setup_cpu_clockevents() Boris Ostrovsky
@ 2014-12-22 16:09 ` David Vrabel
2014-12-22 16:09 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: David Vrabel @ 2014-12-22 16:09 UTC (permalink / raw)
To: Boris Ostrovsky, xen-devel
Cc: Linux Kernel Mailing List, Thomas Gleixner, David Vrabel
On 22/12/14 15:53, Boris Ostrovsky wrote:
> With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in
> native_smp_prepare_cpus()) HVM guests no longer boot since we are
> hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().
>
> I don't think we need this test (PV or HVM), do we?
It looks safe to remove the BUG_ON().
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Testing preemptibility test in xen_setup_cpu_clockevents()
2014-12-22 15:53 Testing preemptibility test in xen_setup_cpu_clockevents() Boris Ostrovsky
2014-12-22 16:09 ` [Xen-devel] " David Vrabel
@ 2014-12-22 16:09 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: David Vrabel @ 2014-12-22 16:09 UTC (permalink / raw)
To: Boris Ostrovsky, xen-devel
Cc: Thomas Gleixner, Linux Kernel Mailing List, David Vrabel
On 22/12/14 15:53, Boris Ostrovsky wrote:
> With 250a1ac685f (x86, smpboot: Remove pointless preempt_disable() in
> native_smp_prepare_cpus()) HVM guests no longer boot since we are
> hitting BUG_ON(preemptible()) in xen_setup_cpu_clockevents().
>
> I don't think we need this test (PV or HVM), do we?
It looks safe to remove the BUG_ON().
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-22 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 15:53 Testing preemptibility test in xen_setup_cpu_clockevents() Boris Ostrovsky
2014-12-22 16:09 ` [Xen-devel] " David Vrabel
2014-12-22 16:09 ` David Vrabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.