Re: [PATCH 1/4] x86: expose CMT L3 event mask to user space

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 23/12/2014 08:54, Chao Peng wrote:
> L3 event mask indicates the event types supported in host, including
> cache occupancy event as well as local/total memory bandwidth events
> for Memory Bandwidth Monitoring(MBM). Expose it so all these events
> can be monitored in user space.
>
> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>   xen/arch/x86/sysctl.c       |    5 +++++
>   xen/include/public/sysctl.h |    1 +
>   2 files changed, 6 insertions(+)
>
> diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
> index 57ad992..0f08038 100644
> --- a/xen/arch/x86/sysctl.c
> +++ b/xen/arch/x86/sysctl.c
> @@ -157,6 +157,11 @@ long arch_do_sysctl(
>               sysctl->u.psr_cmt_op.u.data = (ret ? 0 : info.size);
>               break;
>           }
> +        case XEN_SYSCTL_PSR_CMT_get_l3_event_mask:
> +        {
> +            sysctl->u.psr_cmt_op.u.data = psr_cmt->l3.features;
> +            break;
> +        }
>           default:
>               sysctl->u.psr_cmt_op.u.data = 0;
>               ret = -ENOSYS;
> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> index b3713b3..8552dc6 100644
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -641,6 +641,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_sysctl_coverage_op_t);
>   /* The L3 cache size is returned in KB unit */
>   #define XEN_SYSCTL_PSR_CMT_get_l3_cache_size         2
>   #define XEN_SYSCTL_PSR_CMT_enabled                   3
> +#define XEN_SYSCTL_PSR_CMT_get_l3_event_mask         4
>   struct xen_sysctl_psr_cmt_op {
>       uint32_t cmd;       /* IN: XEN_SYSCTL_PSR_CMT_* */
>       uint32_t flags;     /* padding variable, may be extended for future use */