From: Chao Peng <chao.p.peng@linux.intel.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com,
xen-devel@lists.xen.org, JBeulich@suse.com
Subject: Re: [PATCH 3/4] tools: libxl: code preparation for MBM
Date: Tue, 6 Jan 2015 18:12:21 +0800 [thread overview]
Message-ID: <20150106101221.GD3279@pengc-linux.bj.intel.com> (raw)
In-Reply-To: <20150106095137.GB14301@zion.uk.xensource.com>
On Tue, Jan 06, 2015 at 09:51:37AM +0000, Wei Liu wrote:
> On Tue, Jan 06, 2015 at 05:46:12PM +0800, Chao Peng wrote:
> [...]
> > > Coding style, no space after "(" and before ")".
> > >
> > > I missed this issue when I reviewed your previous patches. You can fix
> > > this style problem here while you're at it.
> > Sure, I will fix them all.
>
> If you plan to fix them all and there are many instances, please use
> preparatory patch -- don't mix them with functional changes.
I noticed this. So I will certainly follow your suggestion :)
Chao
next prev parent reply other threads:[~2015-01-06 10:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 8:54 [PATCH 0/4] enable Memory Bandwidth Monitoring (MBM) for VMs Chao Peng
2014-12-23 8:54 ` [PATCH 1/4] x86: expose CMT L3 event mask to user space Chao Peng
2014-12-23 15:47 ` Andrew Cooper
2015-01-07 8:53 ` Jan Beulich
2014-12-23 8:54 ` [PATCH 2/4] tools: libxc: add routine to get CMT L3 event mask Chao Peng
2014-12-23 15:46 ` Andrew Cooper
2014-12-24 8:33 ` Chao Peng
2014-12-23 8:54 ` [PATCH 3/4] tools: libxl: code preparation for MBM Chao Peng
2015-01-05 12:25 ` Wei Liu
2015-01-06 9:46 ` Chao Peng
2015-01-06 9:51 ` Wei Liu
2015-01-06 10:12 ` Chao Peng [this message]
2014-12-23 8:54 ` [PATCH 4/4] tools: add total/local memory bandwith monitoring Chao Peng
2015-01-05 12:39 ` Wei Liu
2015-01-06 10:09 ` Chao Peng
2015-01-06 10:29 ` Andrew Cooper
2015-01-07 0:54 ` Chao Peng
2015-01-15 8:46 ` Chao Peng
2014-12-23 15:47 ` [PATCH 0/4] enable Memory Bandwidth Monitoring (MBM) for VMs Andrew Cooper
2014-12-24 8:35 ` Chao Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106101221.GD3279@pengc-linux.bj.intel.com \
--to=chao.p.peng@linux.intel.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.