From: Andrew Jackson <Andrew.Jackson@arm.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Pawel Moll <Pawel.Moll@arm.com>, Arnd Bergmann <arnd@arndb.de>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rajeev Kumar <rajeevkumar.linux@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/5] ASoC: dwc: Prepare clock before use
Date: Wed, 24 Dec 2014 06:56:20 +0000 [thread overview]
Message-ID: <549A6394.10507@arm.com> (raw)
In-Reply-To: <63becb5f356c25b226b9dbc5825357e894d0f08b.1419342218.git.Andrew.Jackson@arm.com>
On 12/23/14 13:56, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
>
> Some I2S clocks may require some time to get the clock ready
> for operation and so need to be prepared before they are enabled.
> So, prepare the clock as well as enabling it, but combine the
> two through clk_prepare_enable.
More turkey-focussed issues: this should have a clk_disable_unprepare too. Sigh
Andrew
> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
> ---
> sound/soc/dwc/designware_i2s.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 06d3a34..9573ec7 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -411,7 +411,7 @@ static int dw_i2s_probe(struct platform_device *pdev)
> if (IS_ERR(dev->clk))
> return PTR_ERR(dev->clk);
>
> - ret = clk_enable(dev->clk);
> + ret = clk_prepare_enable(dev->clk);
> if (ret < 0)
> goto err_clk_put;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew.Jackson@arm.com (Andrew Jackson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] ASoC: dwc: Prepare clock before use
Date: Wed, 24 Dec 2014 06:56:20 +0000 [thread overview]
Message-ID: <549A6394.10507@arm.com> (raw)
In-Reply-To: <63becb5f356c25b226b9dbc5825357e894d0f08b.1419342218.git.Andrew.Jackson@arm.com>
On 12/23/14 13:56, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
>
> Some I2S clocks may require some time to get the clock ready
> for operation and so need to be prepared before they are enabled.
> So, prepare the clock as well as enabling it, but combine the
> two through clk_prepare_enable.
More turkey-focussed issues: this should have a clk_disable_unprepare too. Sigh
Andrew
> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
> ---
> sound/soc/dwc/designware_i2s.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 06d3a34..9573ec7 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -411,7 +411,7 @@ static int dw_i2s_probe(struct platform_device *pdev)
> if (IS_ERR(dev->clk))
> return PTR_ERR(dev->clk);
>
> - ret = clk_enable(dev->clk);
> + ret = clk_prepare_enable(dev->clk);
> if (ret < 0)
> goto err_clk_put;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jackson <Andrew.Jackson@arm.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rajeev Kumar <rajeevkumar.linux@gmail.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/5] ASoC: dwc: Prepare clock before use
Date: Wed, 24 Dec 2014 06:56:20 +0000 [thread overview]
Message-ID: <549A6394.10507@arm.com> (raw)
In-Reply-To: <63becb5f356c25b226b9dbc5825357e894d0f08b.1419342218.git.Andrew.Jackson@arm.com>
On 12/23/14 13:56, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
>
> Some I2S clocks may require some time to get the clock ready
> for operation and so need to be prepared before they are enabled.
> So, prepare the clock as well as enabling it, but combine the
> two through clk_prepare_enable.
More turkey-focussed issues: this should have a clk_disable_unprepare too. Sigh
Andrew
> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
> ---
> sound/soc/dwc/designware_i2s.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 06d3a34..9573ec7 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -411,7 +411,7 @@ static int dw_i2s_probe(struct platform_device *pdev)
> if (IS_ERR(dev->clk))
> return PTR_ERR(dev->clk);
>
> - ret = clk_enable(dev->clk);
> + ret = clk_prepare_enable(dev->clk);
> if (ret < 0)
> goto err_clk_put;
>
>
next prev parent reply other threads:[~2014-12-24 6:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 13:56 [PATCH v4 0/5] ASoC: dwc: Add device tree support to designware I2S Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 1/5] ASoC: dwc: Prepare clock before use Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
2014-12-24 6:56 ` Andrew Jackson [this message]
2014-12-24 6:56 ` Andrew Jackson
2014-12-24 6:56 ` Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 2/5] ASoC: dwc: Switch to managed clock resource Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
2014-12-24 6:54 ` Andrew Jackson
2014-12-24 6:54 ` Andrew Jackson
2014-12-24 6:54 ` Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 3/5] ASoC: dwc: Read I2S block configuration from registers Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
[not found] ` <cover.1419342218.git.Andrew.Jackson-5wv7dgnIgG8@public.gmane.org>
2014-12-23 13:56 ` [PATCH v4 4/5] ASoC: dwc: Add documentation for I2S DT Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 5/5] ASoC: dwc: Add devicetree support for Designware I2S Andrew Jackson
2014-12-23 13:56 ` Andrew Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549A6394.10507@arm.com \
--to=andrew.jackson@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rajeevkumar.linux@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.