All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org
Subject: Re: regression bisected; KVM: entry failed, hardware error 0x80000021
Date: Sat, 27 Dec 2014 20:33:54 +0100	[thread overview]
Message-ID: <549F09A2.2050903@redhat.com> (raw)
In-Reply-To: <549BC0D9.6040801@intel.com>



On 25/12/2014 08:46, Chen, Tiejun wrote:
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index f528343..910bc48 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -672,6 +672,7 @@ static void update_memslots(struct kvm_memslots *slots,
>         WARN_ON(mslots[i].id != id);
>         if (!new->npages) {
>                 new->base_gfn = 0;
> +               new->flags = 0;
>                 if (mslots[i].npages)
>                         slots->used_slots--;
>         } else {

Why is this assignment needed?

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>,
	kvm list <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	luto@amacapital.net, jamie@audible.transient.net
Subject: Re: regression bisected; KVM: entry failed, hardware error 0x80000021
Date: Sat, 27 Dec 2014 20:33:54 +0100	[thread overview]
Message-ID: <549F09A2.2050903@redhat.com> (raw)
In-Reply-To: <549BC0D9.6040801@intel.com>



On 25/12/2014 08:46, Chen, Tiejun wrote:
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index f528343..910bc48 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -672,6 +672,7 @@ static void update_memslots(struct kvm_memslots *slots,
>         WARN_ON(mslots[i].id != id);
>         if (!new->npages) {
>                 new->base_gfn = 0;
> +               new->flags = 0;
>                 if (mslots[i].npages)
>                         slots->used_slots--;
>         } else {

Why is this assignment needed?

Paolo

  parent reply	other threads:[~2014-12-27 19:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-21 12:46 regression bisected; KVM: entry failed, hardware error 0x80000021 Jamie Heilman
2014-12-22  7:30 ` Chen, Tiejun
2014-12-22  9:23   ` Jamie Heilman
2014-12-23  1:50     ` Chen, Tiejun
2014-12-23  1:54       ` Chen, Tiejun
2014-12-23  7:26         ` Jamie Heilman
2014-12-23  7:50           ` Chen, Tiejun
2014-12-24  8:29           ` Chen, Tiejun
2014-12-24 11:02             ` Jamie Heilman
2014-12-24 11:11               ` Paolo Bonzini
2014-12-25  7:56                 ` Chen, Tiejun
2014-12-25  7:46               ` Chen, Tiejun
2014-12-25 10:52                 ` Jamie Heilman
2014-12-26  1:44                   ` Chen, Tiejun
2014-12-27 19:33                 ` Paolo Bonzini [this message]
2014-12-27 19:33                   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549F09A2.2050903@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.