From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Andrew Jackson <andrew.jackson@arm.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
pawel.moll@arm.com, Arnd Bergmann <arnd@arndb.de>,
ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
Liviu Dudau <Liviu.Dudau@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rajeev Kumar <rajeevkumar.linux@gmail.com>,
robh+dt@kernel.org, galak@codeaurora.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/6] ASoC: dwc: Prepare clock before use
Date: Tue, 30 Dec 2014 15:39:48 +0300 [thread overview]
Message-ID: <54A29D14.6000705@cogentembedded.com> (raw)
In-Reply-To: <faa0193d388fe808c2fae461954bb1730ba29244.1419936132.git.Andrew.Jackson@arm.com>
Hello.
On 12/30/2014 1:55 PM, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
> Some I2S clocks may require some time to get the clock ready
> for operation and so need to be prepared before they are enabled.
> So, prepare the clock as well as enabling it, but combine the
> two through clk_prepare_enable.
> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
> ---
> sound/soc/dwc/designware_i2s.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 5e9d163..08608c1 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
[...]
> @@ -426,13 +426,16 @@ static int dw_i2s_probe(struct platform_device *pdev)
[...]
> static int dw_i2s_remove(struct platform_device *pdev)
> {
> + struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev);
Why not just platform_get_drvdata(pdev)?
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/6] ASoC: dwc: Prepare clock before use
Date: Tue, 30 Dec 2014 15:39:48 +0300 [thread overview]
Message-ID: <54A29D14.6000705@cogentembedded.com> (raw)
In-Reply-To: <faa0193d388fe808c2fae461954bb1730ba29244.1419936132.git.Andrew.Jackson@arm.com>
Hello.
On 12/30/2014 1:55 PM, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
> Some I2S clocks may require some time to get the clock ready
> for operation and so need to be prepared before they are enabled.
> So, prepare the clock as well as enabling it, but combine the
> two through clk_prepare_enable.
> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
> ---
> sound/soc/dwc/designware_i2s.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 5e9d163..08608c1 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
[...]
> @@ -426,13 +426,16 @@ static int dw_i2s_probe(struct platform_device *pdev)
[...]
> static int dw_i2s_remove(struct platform_device *pdev)
> {
> + struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev);
Why not just platform_get_drvdata(pdev)?
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-12-30 12:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 10:55 [PATCH v5 0/6] ASoC: dwc: Add device tree support to designware I2S Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 1/6] ASoC: dwc: Switch to managed clock resource Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
[not found] ` <af6e23a9f11ead4b8abd1f70dbf634964253b37f.1419936132.git.Andrew.Jackson-5wv7dgnIgG8@public.gmane.org>
2014-12-30 16:49 ` Mark Brown
2014-12-30 16:49 ` Mark Brown
2014-12-30 16:49 ` Mark Brown
2014-12-30 10:55 ` [PATCH v5 2/6] ASoC: dwc: Prepare clock before use Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 12:39 ` Sergei Shtylyov [this message]
2014-12-30 12:39 ` Sergei Shtylyov
2014-12-30 16:51 ` Mark Brown
2014-12-30 16:51 ` Mark Brown
2014-12-30 10:55 ` [PATCH v5 3/6] ASoC: dwc: Read I2S block configuration from registers Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 4/6] ASoC: dwc: Register components with managed interface Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 5/6] ASoC: dwc: Add documentation for I2S DT Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
2014-12-30 16:52 ` Mark Brown
2014-12-30 16:52 ` Mark Brown
2014-12-30 10:55 ` [PATCH v5 6/6] ASoC: dwc: Add devicetree support for Designware I2S Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson
[not found] ` <8da45b000fb1f9a029b30fcf5abe50941f45e32e.1419936132.git.Andrew.Jackson-5wv7dgnIgG8@public.gmane.org>
2014-12-30 16:53 ` Mark Brown
2014-12-30 16:53 ` Mark Brown
2014-12-30 16:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A29D14.6000705@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Liviu.Dudau@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew.jackson@arm.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rajeevkumar.linux@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.